1048087 - [Keyboard] Keyboard layout for "ja" locale is not defined in build config

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Masahiko Imanaka [:marsf]]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140716183446

Steps to reproduce:

Japanese locale code is misconfigured in "/build/config/keyboard-layouts.json".
Correct code for Japanese is "ja".
The json file was introduced in bug 920431. Therefore, this may affects to 1.4 and later.



Actual results:

  "jp": [
      {"layoutId": "jp-kanji", "app": ["apps", "keyboard"]},
      {"layoutId": "en", "app": ["apps", "keyboard"]}
  ],


Expected results:

  "ja": [
      {"layoutId": "jp-kanji", "app": ["apps", "keyboard"]},
      {"layoutId": "en", "app": ["apps", "keyboard"]}
  ],

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi,
The naming is to reference the following file,
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/layouts/jp-kanji.js

[3rd-party-keyboard] flag was used to track the work around 3rd-party keyboard, so should be not applied to this bug.

Comment 2

[Masahiko Imanaka [:marsf]]

Hi,

I'm understanding the layoutID is reference to "jp-kanji.js".
I mentioned in this bug is the system locale code, the part of "jp :[".

Comment 3

[Masahiko Imanaka [:marsf]]

Attachment: Bug1048087.txt

https://github.com/mozilla-b2g/gaia/pull/22462

If I don't have mistakes, could you please take care of this?
Thanks.

Comment 4

[Masahiko Imanaka [:marsf]]

This bug enables Japanese IME by default on ja locale without specifying GAIA_KEYBOARD_LAYOUTS.
This is not critical, but just a typo.

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8466862 [details] [review]
Bug1048087.txt

This looks okay to me, but I'd rather that Rudy reviewed it. I'm no longer familiar with how the keyboard_layouts.json file is used. I think that this change may affect some or all of: 

  the build system
  the setting app
  the FTU app

But things have changed a lot since I last worked on that part of the code so I'm not sure anymore.

Comment 6

[Masahiko Imanaka [:marsf]]

(In reply to David Flanagan [:djf] from comment #5)
> I think that this change may affect some or all of: 
> 
>   the build system
>   the setting app
>   the FTU app
> 

I couldn't find the typo used as system locale code in any other apps or config files.

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8466862 [details] [review]
Bug1048087.txt

Yes, you're right.
Thanks for the correction.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/a0b79fef1f158fadc7d794202a680a75eea82f04