Closed Bug 1048120 Opened 10 years ago Closed 7 years ago

Cannot hide caption of video

Categories

(Websites Graveyard :: mozilla.jp, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: alice0775, Assigned: bugzilla, NeedInfo)

References

Details

(Keywords: regression)

[Tracking Requested - why for this release]: Regression since Firefox31

Steps To Reproduce:
1. Open http://www.mozilla.jp/about/mozilla/
2. Play video
3. Click あ/A icon and Select なし to hide caption

Actual Results:
caption displays

Expected Results:
caption should disappear
Keywords: regression
Summary: Cannot hide caption → Cannot hide caption of video
media.webvtt.enabled  = false helps

Regression window
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/07e357311cf3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131202095303
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/76e799f77069
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131202101149
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=07e357311cf3&tochange=76e799f77069

Regressed by: 
76e799f77069	Ralph Giles — Bug 887978 - Enable WebVTT. r=cpearce, bz New global interfaces need to be added to test_interfaces.html and marked with the same conditional as the pref. The test must also be updated if the conditional is changed on the pref. We now pass the track element portion of the imptests.

Disabled Bug 887978 by Bug 981280 in Firefox28, 29 and 30 but not Firefox31+
Blocks: 887978
Depends on: 981280
[Tracking Requested - why for this release]:
Flags: needinfo?(rillian)
This is not a bug.

If I run the following code: 

``
$('video').prop('textTracks')[0].mode = 'disabled';
``

The textTrack is hidden as expected. As it turns out the JS of this site is just bad. If you look into the JS it reveals the problem (i.e: http://www.mozilla.jp/static/scripts/mj/global-20140512.js at line 1026-1034):

``
          if (native_track_supported) {
            // TODO: HTML5 TextTrack 対応
          } else {
            if (!$(this).attr('lang')) {
              $('#video-subtitles p').aria('hidden', true);
            } else {
              $('#video-subtitles p[lang="' + $(this).attr('lang') + '"]').aria('hidden', false);
            }
          }
``
Assignee: nobody → bugzilla
Component: Video/Audio → www.mozilla.jp
Product: Core → Websites
Version: 31 Branch → unspecified
Assignee: bugzilla → nobody
Component: www.mozilla.jp → Developer Tools: 3D View
Product: Websites → Firefox
change of component to get the tracking flags back.
Assignee: nobody → bugzilla
Component: Developer Tools: 3D View → www.mozilla.jp
Product: Firefox → Websites
The custom video player has been removed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Product: Websites → Websites graveyard
You need to log in before you can comment on or make changes to this bug.