1048138 - Re-enable notification marionnette tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:gerard-majax]

Those tests have been disabled because of some intermittences when turning on Gaia-Try on TPBL. But we cannot live without them!

Comment 1

[:gerard-majax]

Attachment: Gaia PR

Comment 2

[:gerard-majax]

Attachment: Gaia-Try

Comment 3

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> Created attachment 8466921 [details]
> Gaia-Try

So that's fun: there is a lot of similar failures, but it's on other tests. Our tests seems to be green.

Comment 4

[:gerard-majax]

Attachment: Gaia-Try

This is a new Gaia-Try

Comment 5

[:gerard-majax]

Okay so I can reproduce the issue locally. After the fifth run:

  Desktop Notifications
    ✓ should be cleared after opening app (9458ms)

  Notification events
    ✓ click event starts application (4867ms)
    ✓ close event removes notification (5120ms)
    ✓ closing notification invokes close handler (2736ms)
    ✓ click event on resent notification starts application (5462ms)
    ✓ close event removes resent notification (5952ms)

  Notification.get():
    ✓ promise is fulfilled 
    ✓ promise returns a new notification 
    ✓ get works with tag option 
    1) "before each" hook

  9 passing (1m)
  1 failing

  1) Notification.get(): "before each" hook:
     Uncaught 
  Error: Polling socket recv() timeout!
      at TcpSync._readResponse (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:140:30)
      at TcpSync.send (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:24)
      at Object.send (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
      at Object._newSession (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:549:19)
      at /home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:735:14
      at Object.<anonymous> (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:529:11)
      at Object.Client._handleCallback (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:484:23)
      at /home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21
      at TcpSync.send (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:153:10)
      at Object.send (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)
      at Object.Client._sendCommand (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)
      at Object._getActorId (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:526:19)
      at Object.startSession (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:733:19)
      at /home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-js-runner/lib/runtime/hostmanager.js:96:16
      at TcpSync.<anonymous> (/home/alex/codaz/Mozilla/b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:112:7)
      at process._tickCallback (node.js:419:13)



make: *** [test-integration-test] Erreur 1

Comment 6

[:gerard-majax]

I'm wondering if it could not be blocked by bug 1037924.

Comment 7

[Kevin Grandon :kgrandon]

(In reply to Alexandre LISSY :gerard-majax from comment #6)
> I'm wondering if it could not be blocked by bug 1037924.

Looking at the output of your try run I think you are correct. I didn't see the notifications test fail outside of that issue. You can go ahead and land if you want, R=kgrandon if desired.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

I don't think there is any rush to land this. Given the intermittent rate in gaia-try [1], I don't think having this test enabled gives us any useful info to prevent regressions.

1.) https://tbpl.mozilla.org/?rev=068b7106b35596577e71b6f841b9d3cdf72abbc3&tree=Gaia-Try

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Michael Henretty [:mhenretty] from comment #8)
> I don't think there is any rush to land this. Given the intermittent rate in
> gaia-try [1], I don't think having this test enabled gives us any useful
> info to prevent regressions.
> 
> 1.)
> https://tbpl.mozilla.org/
> ?rev=068b7106b35596577e71b6f841b9d3cdf72abbc3&tree=Gaia-Try

Sure, but a perma-fail is still fairly easy to identify. If we can re-enable the test and it's not failing I think it makes sense to do so.

Solving bug 1037924 should absolutely be our highest priority though.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Gaia-Try for notification.get tests:
https://tbpl.mozilla.org/?rev=373b169fe6ea337df9250c1e8a7c74107d3de759&tree=Gaia-Try

Gaia-Try for mozResend tests:
https://tbpl.mozilla.org/?rev=cdc73087993ae3da7499b443140e565e074a7aa4&tree=Gaia-Try

Comment 11

[:gerard-majax]

(In reply to Michael Henretty [:mhenretty] from comment #10)
> Gaia-Try for notification.get tests:
> https://tbpl.mozilla.org/
> ?rev=373b169fe6ea337df9250c1e8a7c74107d3de759&tree=Gaia-Try
> 
> Gaia-Try for mozResend tests:
> https://tbpl.mozilla.org/
> ?rev=cdc73087993ae3da7499b443140e565e074a7aa4&tree=Gaia-Try

Still lots of red :(

Comment 12

[Kevin Grandon :kgrandon]

It appears this was landed when we had a perma-failure. You should be good to rebase this and try again, but it appears that notification_resend_test.js might still be failing.

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Rebased again.

Notification.get()
https://tbpl.mozilla.org/?rev=05ee2942c2dbe6a740721f21a1da5c98d64f37c2&tree=Gaia-Try

Resend Notification
https://tbpl.mozilla.org/?rev=b2253aabb10d5e8446f74acf7454938ec4fda17a&tree=Gaia-Try

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Looks like resend notifications is perma-red. But notification.get tests are probably ready to be re-enabled.

Comment 15

[:gerard-majax]

Triggered a new try: https://tbpl.mozilla.org/?rev=762ce8f7af4313d64353a67e4e340ab03f10e11c&tree=Gaia-Try

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

All dependencies resolved, all notification tests re-enabled. Closing.