Closed
Bug 1048143
Opened 10 years ago
Closed 10 years ago
Should disable FTU and lockscreen when doing keyboard integration test
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(b2g-v2.1 fixed)
RESOLVED
FIXED
2.1 S2 (15aug)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | fixed |
People
(Reporter: rudyl, Assigned: rudyl)
References
Details
(Whiteboard: [p=1])
Attachments
(1 file)
Keyboard integration tests were always run with FTU at the background because we launch a testing app which contains only an input field.
With bug 1046542, it might not be able to access the utility tray for keyboard switching, so we should disable FTU first before doing any keyboard app, and this is more reasonable.
Assignee | ||
Updated•10 years ago
|
Summary: Should disable FTU when doing keyboard integration test → Should disable FTU and lockscreen when doing keyboard integration test
Assignee | ||
Comment 1•10 years ago
|
||
Gij failed for a strange reason, just re-triggered it to see if it is permanent.
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8467003 [details] [review]
Patch V1
Now it looks good on Gaia-try.
Evan, could you please help review this change?
Thank you.
Attachment #8467003 -
Flags: review?(evanxd)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8467003 [details] [review]
Patch V1
Seems Evan is not available to review this in a timely manner.
Re-direct the review to George.
George, could you help on this?
Thank you.
Attachment #8467003 -
Flags: review?(evanxd) → review?(gduan)
Comment 4•10 years ago
|
||
Comment on attachment 8467003 [details] [review]
Patch V1
r=gduan
thanks for the quick patch!
Attachment #8467003 -
Flags: review?(gduan) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/95e2225a14bf8ac1ff5046923bf69b64015fa4cd
--
George, thanks for the review.
Comment 6•10 years ago
|
||
Thanks for George's help.
Comment 7•10 years ago
|
||
I was busy on 2.1 feature yesterday.
You need to log in
before you can comment on or make changes to this bug.
Description
•