Closed Bug 1048144 Opened 7 years ago Closed 7 years ago

Loop button looks blurry in menu-panel and palette

Categories

(Hello (Loop) :: Client, defect, P3)

defect
Points:
1

Tracking

(firefox34 verified)

VERIFIED FIXED
34 Sprint 1- 8/4
Tracking Status
firefox34 --- verified
Blocking Flags:
backlog mlp?

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

Attachments

(3 files, 1 obsolete file)

We need an updated version of menuPanel.png for all platforms that includes an icon for Loop.

Michael, could you attach the updated images to this bug?
Flags: needinfo?(mmaslaney)
backlog: --- → mlp?
Whiteboard: [qa+]
On Windows 7 the icon is not blurry it's simply not the right one that's used and it has no animation.

The menu and palette icons seem to be included in the attachment of bug 1008201 though.
Hm. I misinterpreted those icons; I thought they were meant for the status bar. Different menu.

I'll post a patch that uses the icons in the zip file.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(mmaslaney)
Iteration: 34.1 → ---
(In reply to Guillaume C. [:ge3k0s] from comment #1)
> On Windows 7 the icon is not blurry it's simply not the right one that's
> used and it has no animation.
Also the text is misaligned in the palette on Win and Mac. Seems to be fine on Linux
follow-up!

This also adds a wiggle animation on mousedown in the palette for these type of buttons.

The text alignment issues should be resolved with the correctly sized icons in the menu panel.
Attachment #8467081 - Flags: review?(jaws)
Comment on attachment 8467081 [details] [diff] [review]
Patch v1: add menu panel versions of the Loop icon

Review of attachment 8467081 [details] [diff] [review]:
-----------------------------------------------------------------

The text is still misaligned for me on Windows 7, and the icon is using the wrong shading on Aero (should have a dark blue tint, except it's grey, same as bug 1048103) http://screencast.com/t/HUFeD1csx
Attachment #8467081 - Flags: review?(jaws) → review-
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> The text is still misaligned for me on Windows 7, and the icon is using the
> wrong shading on Aero (should have a dark blue tint, except it's grey, same
> as bug 1048103) http://screencast.com/t/HUFeD1csx

Michael, could you provide updated Win7 menu-panel icons that do have a blue aero tint?

Thanks!
Flags: needinfo?(mmaslaney)
Let me know if there are additional assets missing.
Flags: needinfo?(mmaslaney)
Patch with new aero icons and fixed palette alignment for badge buttons.
Attachment #8467081 - Attachment is obsolete: true
Attachment #8468522 - Flags: review?(jaws)
Comment on attachment 8468522 [details] [diff] [review]
Patch v2: add menu panel versions of the Loop icon

Review of attachment 8468522 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if all you need to do is make the following change to fix the mouseup transition.

::: browser/themes/shared/customizableui/customizeMode.inc.css
@@ +204,5 @@
>    transition: none;
>  }
>  
>  toolbarpaletteitem > toolbarbutton > .toolbarbutton-icon,
> +toolbarpaletteitem[mousedown] > toolbarbutton > .toolbarbutton-badge-container > .toolbarbutton-icon,

I think you should remove the [mousedown] attribute here. This is probably the reason that the mouseup transition is broken, http://screencast.com/t/cY7wFa8bj
Attachment #8468522 - Flags: review?(jaws) → review+
Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/fb046105fc73 with comment addressed (animation is smooth from mousedown 'till mouseup!)
https://hg.mozilla.org/mozilla-central/rev/fb046105fc73
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Note that the icon shows no inverted variant in menu panel when in subview.
(In reply to Guillaume C. [:ge3k0s] from comment #12)
> Note that the icon shows no inverted variant in menu panel when in subview.

I sincerely thank you for your continued testing and reporting. @mikedeboer, can you attach a quick patch here to address this?
Flags: needinfo?(mdeboer)
(In reply to Guillaume C. [:ge3k0s] from comment #12)
> Note that the icon shows no inverted variant in menu panel when in subview.

Thanks Guillaume! I'm afraid this was not anticipated by mmaslaney as well. So we'll need to create a new bug for this where I'll needinfo him for updated assets.
Flags: needinfo?(mdeboer)
Depends on: 1052711
Flags: qe-verify+
QA Contact: anthony.s.hughes
Whiteboard: [qa+]
The Loop icon is no longer blurry and it has animation, the text is aligned in the palette.
Verified fixed 34.0a2 (2014-09-05), Win 7, OS X 10.9.5, Ubuntu 13.04.
Status: RESOLVED → VERIFIED
Depends on: 1165679
You need to log in before you can comment on or make changes to this bug.