1048144 - Loop button looks blurry in menu-panel and palette

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[Mike de Boer [:mikedeboer]]

We need an updated version of menuPanel.png for all platforms that includes an icon for Loop.

Michael, could you attach the updated images to this bug?

Comment 1

[u428464]

On Windows 7 the icon is not blurry it's simply not the right one that's used and it has no animation.

The menu and palette icons seem to be included in the attachment of bug 1008201 though.

Comment 2

[Mike de Boer [:mikedeboer]]

Hm. I misinterpreted those icons; I thought they were meant for the status bar. Different menu.

I'll post a patch that uses the icons in the zip file.

Comment 3

[Paul Silaghi, QA [:pauly]]

Attachment: loop text misaligned.png

(In reply to Guillaume C. [:ge3k0s] from comment #1)
> On Windows 7 the icon is not blurry it's simply not the right one that's
> used and it has no animation.
Also the text is misaligned in the palette on Win and Mac. Seems to be fine on Linux

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: add menu panel versions of the Loop icon

follow-up!

This also adds a wiggle animation on mousedown in the palette for these type of buttons.

The text alignment issues should be resolved with the correctly sized icons in the menu panel.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8467081 [details] [diff] [review]
Patch v1: add menu panel versions of the Loop icon

Review of attachment 8467081 [details] [diff] [review]:
-----------------------------------------------------------------

The text is still misaligned for me on Windows 7, and the icon is using the wrong shading on Aero (should have a dark blue tint, except it's grey, same as bug 1048103) http://screencast.com/t/HUFeD1csx

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> The text is still misaligned for me on Windows 7, and the icon is using the
> wrong shading on Aero (should have a dark blue tint, except it's grey, same
> as bug 1048103) http://screencast.com/t/HUFeD1csx

Michael, could you provide updated Win7 menu-panel icons that do have a blue aero tint?

Thanks!

Comment 7

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: loop-menu-Windows-aero.png

Let me know if there are additional assets missing.

Comment 8

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2: add menu panel versions of the Loop icon

Patch with new aero icons and fixed palette alignment for badge buttons.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8468522 [details] [diff] [review]
Patch v2: add menu panel versions of the Loop icon

Review of attachment 8468522 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if all you need to do is make the following change to fix the mouseup transition.

::: browser/themes/shared/customizableui/customizeMode.inc.css
@@ +204,5 @@
>    transition: none;
>  }
>  
>  toolbarpaletteitem > toolbarbutton > .toolbarbutton-icon,
> +toolbarpaletteitem[mousedown] > toolbarbutton > .toolbarbutton-badge-container > .toolbarbutton-icon,

I think you should remove the [mousedown] attribute here. This is probably the reason that the mouseup transition is broken, http://screencast.com/t/cY7wFa8bj

Comment 10

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/fb046105fc73 with comment addressed (animation is smooth from mousedown 'till mouseup!)

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fb046105fc73

Comment 12

[u428464]

Note that the icon shows no inverted variant in menu panel when in subview.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Guillaume C. [:ge3k0s] from comment #12)
> Note that the icon shows no inverted variant in menu panel when in subview.

I sincerely thank you for your continued testing and reporting. @mikedeboer, can you attach a quick patch here to address this?

Comment 14

[Mike de Boer [:mikedeboer]]

(In reply to Guillaume C. [:ge3k0s] from comment #12)
> Note that the icon shows no inverted variant in menu panel when in subview.

Thanks Guillaume! I'm afraid this was not anticipated by mmaslaney as well. So we'll need to create a new bug for this where I'll needinfo him for updated assets.

Comment 15

[Paul Silaghi, QA [:pauly]]

The Loop icon is no longer blurry and it has animation, the text is aligned in the palette.
Verified fixed 34.0a2 (2014-09-05), Win 7, OS X 10.9.5, Ubuntu 13.04.