1048191 - Remove capability to generate non-basic entities (nsIEntityConverter & nsHTMLEntities)

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Henri Sivonen (:hsivonen)]

As far as I can tell, the only Firefox user of this functionality is View Selection Source, the MathML feature in particular. It is also used by the DOM Inspector and Firebug extensions. It seems to me that there are no uses either directly or via nsISaveAsCharset in either Firefox for Android or Firefox OS.

We should stop building nsIEntityConverter and the associated property files for mobile to make Gecko slightly smaller on mobile.

Comment 1

[Henri Sivonen (:hsivonen)]

The View MathML Source feature is now available as a Web Extension:
https://groups.google.com/d/msg/mozilla.dev.platform/SMfaMDhTXy8/Wu26wIYfCQAJ

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

Review commit: https://reviewboard.mozilla.org/r/164842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164842/

Comment 3

[Mozilla Autoland]

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 14 changesets with 50 changes to 40 files (+1 heads)
remote: autoland push detected
remote: recorded push in pushlog
remote: 
remote: View the pushlog for these changes here:
remote:   https://hg.mozilla.org/try/pushloghtml?changeset=82464b3a6ebda4b5b27ad7ad60301ebe39dceff2
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=82464b3a6ebda4b5b27ad7ad60301ebe39dceff2
remote: recorded changegroup in replication log in 0.053s
remote: ** unknown exception encountered, please report by visiting
remote: ** https://mercurial-scm.org/wiki/BugTracker
remote: ** Python 2.7.5 (default, Nov  6 2016, 00:28:07) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)]
remote: ** Mercurial Distributed SCM (version 4.2.2)
remote: ** Extensions loaded: blackbox, clonebundles, obsolescencehacks, pushlog, serverlog, readonly, vcsreplicator
remote: Traceback (most recent call last):
remote:   File "/var/hg/venv_pash/bin/hg", line 45, in <module>
remote:     mercurial.dispatch.run()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 83, in run
remote:     status = (dispatch(req) or 0) & 255
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 164, in dispatch
remote:     ret = _runcatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 295, in _runcatch
remote:     return _callcatch(ui, _runcatchfunc)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 303, in _callcatch
remote:     return scmutil.callcatch(ui, func)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/scmutil.py", line 146, in callcatch
remote:     return func()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 285, in _runcatchfunc
remote:     return _dispatch(req)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 912, in _dispatch
remote:     cmdpats, cmdoptions)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 648, in runcommand
remote:     ret = _runcommand(ui, options, cmd, d)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 920, in _runcommand
remote:     return cmdfunc()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/dispatch.py", line 909, in <lambda>
remote:     d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/util.py", line 1080, in check
remote:     return func(*args, **kwargs)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/commands.py", line 4663, in serve
remote:     s.serve_forever()
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 320, in serve_forever
remote:     return super(sshserverwrapped, self).serve_forever()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 104, in serve_forever
remote:     while self.serve_one():
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 351, in serve_one
remote:     return super(sshserverwrapped, self).serve_one()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/sshserver.py", line 122, in serve_one
remote:     rsp = wireproto.dispatch(self.repo, self, cmd)
remote:   File "/var/hg/version-control-tools/hgext/serverlog/__init__.py", line 343, in dispatch
remote:     return origdispatch(repo, proto, cmd)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/extensions.py", line 231, in closure
remote:     return func(*(args + a), **kw)
remote:   File "/var/hg/version-control-tools/pylib/vcsreplicator/vcsreplicator/hgext.py", line 359, in wireprotodispatch
remote:     return orig(repo, proto, command)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 570, in dispatch
remote:     return func(repo, proto, *args)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/wireproto.py", line 982, in unbundle
remote:     proto._client())
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/exchange.py", line 1777, in unbundle
remote:     lockandtr[2].close()
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 43, in _active
remote:     return func(self, *args, **kwds)
remote:   File "/var/hg/venv_pash/lib/python2.7/site-packages/mercurial/transaction.py", line 490, in close
remote:     self._postclosecallback[cat](self)
remote:   File "/var/hg/version-control-tools/hgext/pushlog/__init__.py", line 245, in onpostclose
remote:     conn.commit()
remote: sqlite3.OperationalError: database is locked
abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164842/diff/1-2/

Comment 5

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164842/diff/2-3/

Comment 6

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164842/diff/3-4/

Comment 8

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164842/diff/4-5/

Comment 9

[Masatoshi Kimura [:emk]]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

https://reviewboard.mozilla.org/r/164842/#review170498

::: dom/base/nsCopySupport.cpp:562
(Diff revision 5)
>    NS_ENSURE_TRUE(document->IsHTMLDocument(), NS_OK);
>  
>    // init encoder with document and node
>    rv = docEncoder->NativeInit(document, NS_LITERAL_STRING(kHTMLMime),
>                                nsIDocumentEncoder::OutputAbsoluteLinks |
> -                              nsIDocumentEncoder::OutputEncodeW3CEntities);
> +                              nsIDocumentEncoder::OutputEncodeBasicEntities);

What is this used for?

Comment 10

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

https://reviewboard.mozilla.org/r/164842/#review170498

> What is this used for?

It appears to be used for serializing the HTML markup for an `img` element when exporting an image to the clipboard. So this changes what we export to the clipboard, but even before this, we could export unescaped Unicode HTML to the clipboard, so hopefully no one will notice...

Comment 11

[Henri Sivonen (:hsivonen)]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

https://reviewboard.mozilla.org/r/164842/#review170498

> It appears to be used for serializing the HTML markup for an `img` element when exporting an image to the clipboard. So this changes what we export to the clipboard, but even before this, we could export unescaped Unicode HTML to the clipboard, so hopefully no one will notice...

I'd be shocked if receivers supported MathML entities better than they support unescaped Unicode.

Comment 12

[Masatoshi Kimura [:emk]]

Comment on attachment 8893724 [details]
Bug 1048191 - Remove capability to generate entities other than quot, amp, gt, lt and nbsp. .

https://reviewboard.mozilla.org/r/164842/#review170532

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aff598d54bd
Remove capability to generate entities other than quot, amp, gt, lt and nbsp. r=emk.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4aff598d54bd

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/541587cdce4a
Port bug 1048191 to TB/SM/IB: Remove packaging of entityTables. rs=bustage-fix