Closed Bug 1048231 Opened 10 years ago Closed 10 years ago

reload apache on 'hg up'

Categories

(Infrastructure & Operations :: RelOps: Puppet, task)

Product:
Infrastructure & Operations
Component:
RelOps: Puppet
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(2 files)

bug1048231.patch
948 bytes, patch
Callek
: review+
dustin
: checked-in+
Details | Diff | Splinter Review
bug1048231-p1.patch
903 bytes, patch
Callek
: review+
dustin
: checked-in+
Details | Diff | Splinter Review 
We're seeing a lot of problems recently where an update is partially cached by Puppet (3.6.x caches a lot more aggressively than older versions).

A graceful reload (service httpd reload) seems to do the trick.
Attached patch bug1048231.patch — — Splinter Review 
This caused issues this morning, for example.
Attachment #8467189 - Flags: review?(bugspam.Callek)
Comment on attachment 8467189 [details] [diff] [review]
bug1048231.patch

Review of attachment 8467189 [details] [diff] [review]:
-----------------------------------------------------------------

my *only* concern would be if this causes any intermittent 500s when hg updates. (e.g. cert/puppetizing failures, or other puppet errors).

I am presuming of course that httpd reload does not cause that at all.
Attachment #8467189 - Flags: review?(bugspam.Callek) → review+
It shouldn't, but even if it does -- we see those sometimes anyway.
Attachment #8467189 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Huh.. /etc/crontab has

PATH=/sbin:/bin:/usr/sbin:/usr/bin

and

[root@releng-puppet2.srv.releng.scl3.mozilla.com dmitchell]# which service
/sbin/service

yet

/etc/puppet/update.sh: line 76: service: command not found
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This seems to work, though.
Attachment #8467814 - Flags: review?(bugspam.Callek)
Comment on attachment 8467814 [details] [diff] [review]
bug1048231-p1.patch

cron PATH always baffles me
Attachment #8467814 - Flags: review?(bugspam.Callek) → review+
Attachment #8467814 - Flags: checked-in+
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: