1048296 - Landing pages: Webmaker-analytics events tracking is not recording

Status: RESOLVED FIXED

(Webmaker Graveyard :: Engagement Ladder, defect)

Description

[Adam Lofting (:adamlofting)]

The webmaker-analytics library loads correctly, and the tracking event fires. But there seems to be an issue in webmaker-analytics WRT to queuing events for GA to fire after it has loaded.

I will work on the webmaker-analytics library to fix this at source, but in the mean time can we move the GA loading into the head of these landing page templates so that the GA object exists when webmaker-analytics records an event.

Comment 1

[Adam Lofting (:adamlofting)]

Attachment: https://github.com/mozilla/webmaker-landing-pages/pull/42

If you're happy with us moving this to the head, here's the PR.

Comment 2

[Aki Rose Braun [:akirose]]

Comment on attachment 8467087 [details] [review]
https://github.com/mozilla/webmaker-landing-pages/pull/42

This looks great, thanks!

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages

https://github.com/mozilla/webmaker-landing-pages/commit/0c27edc954d533d34db07ae17056a049a417dfdc
Fixes Bug 1048296 - moving GA to head

https://github.com/mozilla/webmaker-landing-pages/commit/6469900f194e1daa2260be35d59050c524f58f68
Merge pull request #42 from adamlofting/bug1048296

Fixes Bug 1048296 - moving GA to head