The webmaker-analytics library loads correctly, and the tracking event fires. But there seems to be an issue in webmaker-analytics WRT to queuing events for GA to fire after it has loaded. I will work on the webmaker-analytics library to fix this at source, but in the mean time can we move the GA loading into the head of these landing page templates so that the GA object exists when webmaker-analytics records an event.
Created attachment 8467087 [details] [review] https://github.com/mozilla/webmaker-landing-pages/pull/42 If you're happy with us moving this to the head, here's the PR.
Attachment #8467087 - Flags: review?(aki)
Comment on attachment 8467087 [details] [review] https://github.com/mozilla/webmaker-landing-pages/pull/42 This looks great, thanks!
Attachment #8467087 - Flags: review?(aki) → review+
Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages https://github.com/mozilla/webmaker-landing-pages/commit/0c27edc954d533d34db07ae17056a049a417dfdc Fixes Bug 1048296 - moving GA to head https://github.com/mozilla/webmaker-landing-pages/commit/6469900f194e1daa2260be35d59050c524f58f68 Merge pull request #42 from adamlofting/bug1048296 Fixes Bug 1048296 - moving GA to head
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.