Closed
Bug 104834
Opened 23 years ago
Closed 23 years ago
tabs toolbar: mouseover raise/hilight feedback for 'close tab' button [X]
Categories
(SeaMonkey :: Tabbed Browser, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: bugzilla, Assigned: hyatt)
References
Details
Attachments
(5 files)
963 bytes,
patch
|
Details | Diff | Splinter Review | |
2.60 KB,
patch
|
Details | Diff | Splinter Review | |
3.52 KB,
patch
|
Details | Diff | Splinter Review | |
3.58 KB,
patch
|
Details | Diff | Splinter Review | |
3.52 KB,
patch
|
Details | Diff | Splinter Review |
It's pretty hard to see when you actually are gonna hit the [X] button in the tabbed browser menuline. Could we have some kind of mouse over effect so that when you move over the button it sticks out like a button....?
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
Added a <xul:toolbarbutton> around the image looks okay in both modern and classic. Also fixed up a hard coded label and moved it to the value in the dtd.
Comment 3•23 years ago
|
||
Comment 4•23 years ago
|
||
tried the patch on linux, worked fine for me, added keyword patch, remove if you think it is unsuitable
Keywords: patch
OS: Windows 2000 → All
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
Comment 5•23 years ago
|
||
this bug is out-of-date because we do not have this [X] box anymore. should be marked as WONTFIX or REMIND and reopened if comes back without a mouseover effect.
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
Comment 8•23 years ago
|
||
My .02 on the latest patch: I don't see any tooltip problems here ... win98se, pulled/built last night. Do we need a label? If so, it should be in a dtd I'm sure, and definitely shouldn't be "bleh" :) Otherwise, I like it. This has been a UI nit of mine for a while.
Comment 9•23 years ago
|
||
whoops, bleh shouldnt have gotten through. new patch coming soon.
Comment 10•23 years ago
|
||
Assignee | ||
Comment 12•23 years ago
|
||
Don't make a unique tooltip hookup on the button. Use the tooltip listener attached to the tab strip already.
Comment 13•23 years ago
|
||
Better yet, don't put a tooltip on the X at all. It's repetitive.
Comment 14•23 years ago
|
||
I agree it's repetitive ... methinks we should have no label, but still have a tooltip.
Comment 15•23 years ago
|
||
There's no label in the latest patch as far as I can tell, which is good. There also doesn't need to be a tooltip, since the X is on the tabstrip.
Comment 16•23 years ago
|
||
*** Bug 111011 has been marked as a duplicate of this bug. ***
Comment 17•23 years ago
|
||
see bug 113879 for why there should be a tooltip. repeating: "x in the upper right" does not mean "close" on all platforms (particularly mac). Also, even windows users may wonder whether "x" will close just their current tab, or close all background tabs and the tab interface, leaving their current web page up. A tooltip removes ambiguity for folks that wonder what the "x" will close, and it exlains what the "x" does for folks who may not know. The "x" is *not* adequately self-explanatory for all users. Next question, should bug 113879 be marked as a dup of this one? I didn't find this bug when I created that one. If the raised button mouseover is resolved, I'm thinking that this bug should be closed and bug 113879 left open for the tooltip issue, OR the summary on this bug should be modified to also address the tooltip issue, and bug 113879 should be made a dup of this one. -matt
Comment 18•23 years ago
|
||
*** Bug 114651 has been marked as a duplicate of this bug. ***
Comment 19•23 years ago
|
||
adding some more likely search terms into summary was: Need mouseover effect on [X] button now: tabs toolbar: mouseover raise/hilight feedback for 'close tab' button [X] -matt
Summary: Need mouseover effect on [X] button → tabs toolbar: mouseover raise/hilight feedback for 'close tab' button [X]
Comment 20•23 years ago
|
||
This has been fixed by hewitts checkin last night (Works in linux build 2001121921).
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 21•23 years ago
|
||
verified on Win2K 2001121909 in both Modern and Classic skins
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•