1048353 - One time tasks need expiration date

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Rebecca Billings [:rbillings]]

One time tasks should expire in one month if they are not completed. This was originally part of bug 1005100, but was never implemented.

- tasks need a claimed expiration date where they are returned to the dashboard, and user claim is removed if the task is not completed in one month

Comment 1

[Bob Silverberg [:bsilverberg]]

Just looking for clarification here: You are not talking about an expiration date that is set when creating the task - you are talking about an automatically calculated expiration date for the task attempt, that will change its status from "Started" to "Abandoned" if not completed within 30 days. Is that correct?

Comment 2

[Rebecca Billings [:rbillings]]

That is correct

Comment 3

[Bob Silverberg [:bsilverberg]]

We are actually going to have a new task attempt status called "Closed" which will be used for automatically closing attempts when a Task expires or becomes invalid. It sounds like we should use that for this case as well, as opposed to "Abandoned". This would also allow us to notify a user if their current attempt were transitioned to this state, as per bug 1030996.

Please confirm that we should change the status to "Closed".

Comment 4

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/167

Comment 5

[Rebecca Billings [:rbillings]]

Closed is not appropriate in this situation. The idea is to return the task to the pool for other people to grab- so it would go back to available. Instead of changing the status, it's more about removing the hold that the user has on the task.

Comment 6

[Bob Silverberg [:bsilverberg]]

I think you may misunderstand. Closed is the status of the Attempt, not the Task. Changing the attempt's status to Closed _would_ return the task to the pool. It just seems to me that *we* are closing the user's attempt, because they took too long. *They* are not abandoning it. Although you could argue they have already abandoned it by not completing it within 30 days.

I am fine with either Abandoned or Closed, but I wanted to make sure I accurately explained the difference. Either status will give us the result we want - it's just a question of how we want the attempt marked. Should it be marked as closed (which means by us), or as abandoned?

Comment 7

[Rebecca Billings [:rbillings]]

You're right- I misunderstood. Yes, closed should be the status of the attempt- it's better than abandoned for the reasons you listed.

Comment 8

[Osmose [:osmose, :mkelly]]

Comment on attachment 8470061 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/167

r+, feedback on Github

Comment 9

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8470061 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/167

Landed in https://github.com/mozilla/oneanddone/commit/2627b2042f2d803167e77baa018dbe5e38d8cfdf

Comment 10

[Bob Silverberg [:bsilverberg]]

I have completed the background task that will check for attempts that:

- have a status of Open
- are for one-time tasks
- have been open for over 30 days

for any that it finds, it will change the status to Closed.

The number 30 is a setting, so it can be changed easily in the future.

This code can be deployed, but it will not do anything until it is either run manually (which we can do for testing purposes) or via a cron job which I will not be setting up yet. We need to have the notifications in place before we can start automatically closing tasks, so that will block scheduling the cron job.

I'm going to make this as fixed, but it won't be sufficiently verifiable until we have the notifications piece in place.

Comment 11

[Rebecca Billings [:rbillings]]

I'd appreciate knowing how to run it manually - or at least setting it up on staging with a really short duration, now that notifications have been implemented.

Comment 12

[Rebecca Billings [:rbillings]]

This was verified