1048356 - Add missing <script src="enableTestPlugin.js"> tag to {file_fullscreen-,test_iframe_sandbox_}plugins.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Biru [:poiru]]

The following failures occured on try when testing moving content/html to dom/html (bug 946065):

 4194 INFO TEST-UNEXPECTED-FAIL | /tests/dom/html/test/test_fullscreen-api.html | Test timed out.
 6352 INFO TEST-UNEXPECTED-FAIL | /tests/dom/html/test/test_iframe_sandbox_plugins.html | uncaught exception - TypeError: p.startWatchingInstanceCount is not a function at http://mochi.test:8888/tests/dom/html/test/test_iframe_sandbox_plugins.html:38

Comment 1

[Biru [:poiru]]

Attachment: Add missing <script src="enableTestPlugin.js"> tag to {file_fullscreen-,test_iframe_sandbox_}plugins.html

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Could you explain why it was broken, and how this fixes it?

Comment 3

[Biru [:poiru]]

(In reply to :Ms2ger from comment #2)
> Could you explain why it was broken, and how this fixes it?

Both tests contain <embed type="application/x-test" ...>, which does not work unless "Test Plug-in" is enabled. In the old location, the plugin was apparently already enabled for some reason. The patch adds the missing <script> tag (test_object_plugin_nav.html[0] already does this), which fixes the issue in the new location.

[0]: http://mxr.mozilla.org/mozilla-central/source/content/html/content/test/test_object_plugin_nav.html#11

Comment 4

[Biru [:poiru]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da0ef2bd67b4

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da0ef2bd67b4