Update to use gaia-header v0.2.6

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: wilsonpage, Assigned: wilsonpage)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(ux-b2g:2.1)

Details

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
Casey Yee
: review+
Details | Review | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

4 years ago
Summary: Update to use gaia-header@0.2.5 → Update to use gaia-header v0.2.5
(Assignee)

Comment 1

4 years ago
Created attachment 8467143 [details]
pull-request (master)
Attachment #8467143 - Flags: review?(yor)
(Assignee)

Comment 2

4 years ago
v0.2.5 comes with:

- Improved l10n shadow-dom solution (see gaia-header readme)
- Bug fix with font-fit.js being run at wrong time
(Assignee)

Updated

4 years ago
Assignee: nobody → wilsonpage
(Assignee)

Comment 3

4 years ago
Created attachment 8467151 [details] [review]
pull-request (master)
Attachment #8467143 - Attachment is obsolete: true
Attachment #8467143 - Flags: review?(yor)
Attachment #8467151 - Flags: review?(yor)
(Assignee)

Updated

4 years ago
Summary: Update to use gaia-header v0.2.5 → Update to use gaia-header v0.2.6
(Assignee)

Updated

4 years ago
Attachment #8467151 - Flags: review?(kyee)

Comment 4

4 years ago
Comment on attachment 8467151 [details] [review]
pull-request (master)

Looks good.  The only suggestion I can make is that the class name for .supported-action should be a bit more descriptive.   Maybe something like .is-visible or .is-hidden

Otherwise looks fine

r+
Attachment #8467151 - Flags: review?(kyee) → review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
ux-b2g: --- → 2.1

Updated

4 years ago
Attachment #8467151 - Flags: review?(yor)
You need to log in before you can comment on or make changes to this bug.