1048392 - Clicking advanced search from a non-Firefox crash report assumes Firefox instead of the non-Firefox product

Status: RESOLVED WONTFIX

(Socorro :: General, task)

Description

[Kevin Brosnan [Ex-Mozilla]]

+++ This bug was initially created as a clone of Bug #1042694 +++

view https://crash-stats.mozilla.com/report/index/d33cee58-b8c3-4bc8-87d8-343432140722

Click on the advanced search link

Expected: FennecAndroid is the product selected

Results: Firefox is the product selected

Comment 1

[Robert Kaiser]

Do we also have a bug on the "More Reports" link?

Comment 2

[Peter Bengtsson [:peterbe]]

Actually, I'm not convinced at all about this. 
I think it's counter-intuitive that the nav changes based on content further within the page. After all, the nav is *above* core content page that page. 

What I think, is that the `?product=...` link to Advanced Search to follow whatever you see in the nav on the left. And when I go to the above mentioned URL it says "Product: [Firefox]" so then I think the nav should reflect that. 

The reason we decoupled the nav from the content of the processed crash JSON data was because sometimes the processed crash JSON data contained values for the `product` key that were not valid products and valid links. For example `/home/products/Not A Known Product`.

What do you think? I'm I being too purist?

Comment 3

[Robert Kaiser]

I understand the nav argument, and that might be fine. In terms of calling up search, the "invalid product" argument probably doesn't have value, though, as invalid argument values should be dealt with anyhow, given that one can feed anything through the URL bar if wanted. ;-)

That said, I think what we should correct in any case is the "Search" link in the "Signature" row of the "Details" tab, which ends up setting itself to the product selected in nav, even though you call it up from within the crash report display.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

(In reply to Kevin Brosnan [:kbrosnan] from comment #0)
> Click on the advanced search link

Are we talking about the "Advanced Search" link from the header of the page, or from the "Search" link that is next to the signature in the Details tab? I would agree with Peter that the link in the header should _not_ change depending on the content, but the one called "Search" in the Details tab should definitely include the product argument. 

(In reply to Robert Kaiser (:[e-mail], slow reaction due to vacation backlog) from comment #1)
> Do we also have a bug on the "More Reports" link?

What's wrong with that one? It does include the product.

Comment 5

[Robert Kaiser]

(In reply to Adrian Gaudebert [:adrian] from comment #4)
> (In reply to Robert Kaiser (:[e-mail], slow reaction due to
> vacation backlog) from comment #1)
> > Do we also have a bug on the "More Reports" link?
> 
> What's wrong with that one? It does include the product.

It linked the wrong product originally, but I guess that already has been fixed in the other bug. Sorry.

Comment 6

[Lonnen :lonnen]

The top level nav remains decoupled, but retesting this and both "search" and "more reports" links in the page appropriately fill in the product from the crash report.