Open Bug 1048399 Opened 10 years ago Updated 2 years ago

Fix instances of |NS_PTR_TO_INT32| >> X that should be |NS_PTR_TO_UINT32| >> X

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

People

(Reporter: erahm, Unassigned)

References

(Blocks 1 open bug)

Details

This is a follow up to bug 1047176, comment 10. 

There are many instances of:
    NS_PTR_TO_INT32(...) >> X

Which really should be:
    NS_PTR_TO_UINT32(...) >> X

This issue is particularly prevalent in hashing functions that return an unsigned, but cast to a signed, do a bit shift, and then implicitly convert to an unsigned again.
Ehsan fixed one of these in bug 1376563.
Depends on: 1376563
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.