1048421 - Use optimizable build-time flags for SDK-dependent code in utils

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Follow-up from Bug 1042383 to hit utils, now that we have Bug 1047674.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Use optimizable build-time flags for SDK-dependent code in utils. v1

Rubberstamp, please!

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8467224 [details] [diff] [review]
Use optimizable build-time flags for SDK-dependent code in utils. v1

Review of attachment 8467224 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/Clipboard.java
@@ +3,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  package org.mozilla.gecko.util;
>  
> +import java.util.concurrent.SynchronousQueue;

Any reason you're moving these other constants around?

::: mobile/android/base/util/PrefUtils.java
@@ +12,5 @@
>  import org.json.JSONException;
> +import org.mozilla.gecko.AppConstants.Versions;
> +
> +import android.content.SharedPreferences;
> +import android.util.Log;

Same - constant moving?

Comment 3

[Richard Newman [:rnewman]]

(In reply to Chenxia Liu [:liuche] from comment #2)

> > +import java.util.concurrent.SynchronousQueue;
> 
> Any reason you're moving these other constants around?

s/constants/imports, but because this is the order they're supposed to be in, and Eclipse is fixing them on my behalf :D

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/2c4ad23ccbc8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2c4ad23ccbc8