Closed Bug 1048421 Opened 7 years ago Closed 7 years ago

Use optimizable build-time flags for SDK-dependent code in utils

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

Follow-up from Bug 1042383 to hit utils, now that we have Bug 1047674.
Summary: Use optimizable build-time flags for SDK-dependent code → Use optimizable build-time flags for SDK-dependent code in utils
Rubberstamp, please!
Attachment #8467224 - Flags: review?(liuche)
Comment on attachment 8467224 [details] [diff] [review]
Use optimizable build-time flags for SDK-dependent code in utils. v1

Review of attachment 8467224 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/util/Clipboard.java
@@ +3,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  package org.mozilla.gecko.util;
>  
> +import java.util.concurrent.SynchronousQueue;

Any reason you're moving these other constants around?

::: mobile/android/base/util/PrefUtils.java
@@ +12,5 @@
>  import org.json.JSONException;
> +import org.mozilla.gecko.AppConstants.Versions;
> +
> +import android.content.SharedPreferences;
> +import android.util.Log;

Same - constant moving?
Attachment #8467224 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #2)

> > +import java.util.concurrent.SynchronousQueue;
> 
> Any reason you're moving these other constants around?

s/constants/imports, but because this is the order they're supposed to be in, and Eclipse is fixing them on my behalf :D
https://hg.mozilla.org/mozilla-central/rev/2c4ad23ccbc8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.