[Vertical Homescreen] Defer saving of grid until after initial render

RESOLVED FIXED in 2.1 S5 (26sep)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
2.1 S5 (26sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.1 wontfix, b2g-v2.2 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Currently we try to save to indexedDB after each source synchronizes. We should be able to shave some time if we save only after the initial render.
(Assignee)

Comment 1

4 years ago
Created attachment 8467325 [details] [review]
Github pull request
(Assignee)

Comment 2

4 years ago
[Blocking Requested - why for this release]: This should save ~100ms on startup.
blocking-b2g: --- → 2.0?
BLocking as this will help the CAF issue in 1048543
blocking-b2g: 2.0? → 2.0+
Whiteboard: [systemsfe]
(Assignee)

Comment 4

4 years ago
Comment on attachment 8467325 [details] [review]
Github pull request

Flagging a few people for review. Chris, I think Cristian/Carmen might be on PTO - if you have a few minutes to help with a review I would appreciate it.
Attachment #8467325 - Flags: review?(crdlc)
Attachment #8467325 - Flags: review?(chrislord.net)
Attachment #8467325 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8467325 [details] [review]
Github pull request

Comments on the pull request.
Attachment #8467325 - Flags: review?(chrislord.net) → review+
Comment on attachment 8467325 [details] [review]
Github pull request

At first look the pr looks good. It works well when SV isn't used and when the system is installed from scratch (that is, it's not upgraded via fota).
But I tested it on a fota scenario and it didn't work (vertical home started up without any apps). For that reason I cannot give the r+ here, sorry.
I'm searching for the reason of failure now.
Attachment #8467325 - Flags: review?(carmen.jimenezcabezas)
(Assignee)

Comment 7

4 years ago
Carmen - Thanks for testing. Can you tell me what version you upgraded fota over? Was it 1.3 -> 2.0 or 2.0 -> 2.0 for example?

Any chance you saw anything in logcat? I will also try to emulate this manually soon.
Flags: needinfo?(carmen.jimenezcabezas)
I've tested it from v1.4 -> master and v1.3 -> master with the same result (I'm afraid).
To discard fota errors, I had tested a update from v1.4 -> master without the current patch too.
The logcat says nothing
Flags: needinfo?(carmen.jimenezcabezas)
(Assignee)

Comment 9

4 years ago
After looking at this again, the main gains here are only for the very first run, and not subsequent runs.

I think we may be able to get some additional time out of this, but I don't think we should shoot for 2.0 as it possibly increases risk to fota updates.

Unblocking for now, but will try to re-measure to get some statistics here.
No longer blocks: 1037706
blocking-b2g: 2.0+ → ---
Comment on attachment 8467325 [details] [review]
Github pull request

Removing my review because I've seen that Chris and Carmen are doing it. Thanks
Attachment #8467325 - Flags: review?(crdlc)
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Kevin, do we still need this?
Flags: needinfo?(kgrandon)
(Assignee)

Comment 12

4 years ago
(In reply to Gregor Wagner [:gwagner] from comment #11)
> Kevin, do we still need this?

Yes, it's something I definitely want. I think the OTA issue should be resolved now as it was something we were seeing before but went away. I would like to verify this before landing though.
Flags: needinfo?(kgrandon)
Target Milestone: 2.1 S3 (29aug) → 2.1 S5 (26sep)
(Assignee)

Comment 13

4 years ago
Unfortunately I am having trouble generating an FOTA update locally, but I am fairly confident in landing this for a few reasons:

1 - I distinctly remember a blank screen after upgrade bug that was resolved in 2.0, but I can't find the bug number.
2 - 1.x -> 2.2 upgrades are not supported, so it should be fine to land this in master and let it ride the 2.2 train.

I'm going to go ahead and land and watch upgrades/keep this bug in mind to make sure it doesn't cause any problems.
(Assignee)

Comment 14

4 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/dd4fbdb8cf75783a8335627d793a2373ee808fe0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → wontfix
status-b2g-v2.2: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.