1048645 - Add "tutorial" images to post-sharing toast

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Chris Kitching [:ckitching]]

As shown in the third slide of the design:
http://delivery.yuuuan.com/du9yadac

On first (or possible first several) use of a button, we show in he toast a fancy tutorial image, instead of a simple message.

Comment 1

[Yuan Wang(:Yuan) – Mobile Firefox Design Lead]

Attachment: Share to Firefox_ first-time tip screenshots.zip

Screenshots of First-time tips

The spec is at:http://cl.ly/image/0o3l2z122H00

Note: The image for Reading list is a bit shorter than the other two images. I would like to have the panel of Reading list also be shorter but keep a consistent margin as the specification.

Thanks!

Comment 2

[Richard Newman [:rnewman]]

N.B., ideally we should show Android screenshots if the remote device is "mobile".

We should apply heuristics to decide whether to show Mac, Windows, or Linux screenshots based on the remote device name.

Comment 3

[Chris Kitching [:ckitching]]

Richard :

* How would such heuristics look? Does sync have default names for things that are useful in this direction? It seems that user-given names are pretty arbitrary : mine is just my hostname...

* This bug needs a way to detect first run for the overlay (maybe first couple thereof).  Is an android shared preference the correct approach for that?

Comment 4

[Richard Newman [:rnewman]]

Desktop names are generated in services/sync/modules/engines/clients.js.

Client names are composed from client.name2, from the user's username, appName, and hostname. E.g.,

  Mac:
    rnewman's Nightly on jetfire

(defaults to "on Richard's MacBook Pro".)

  Windows:
    Richard's Nightly on rnewman-surface


Sync client names on desktop can also be customized. I'd guess that single-word names are likely to be Mac users (or Linux users, but we don't care too much about that), and multiple-word names Windows ("John's laptop" versus a relatable name), but that's only based on a lifetime of interacting with users :)

So, my proposed heuristic, in order:

  ends in "MacBook Pro|MacBook|iMac|Mac mini|iBook|MacBook Air" (case insensitive): Mac
  contains "Windows": Windows
  contains "Toshiba|HP|Dell|Microsoft|Sony": Windows
  single word: Mac
  two words: Windows
  starts with a lowercase letter: Mac
  starts with an uppercase letter: Windows


Sidenote: for Android, see SharedPreferencesClientsDataDelegate.

Client names are composed from sync.default.client.name, using the app name and the model name.

Client names will be (in English), e.g.:

My Kindle Fire:

  {Aurora,Beta,Nightly,Firefox,Fennec .*} on KFTHWI

My phone:

  Nightly on HTC One

Comment 5

[Richard Newman [:rnewman]]

> This bug needs a way to detect first run for the overlay (maybe first
> couple thereof).  Is an android shared preference the correct approach for
> that?

Yes.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Stay on target! My complexity spider-sense was tingling on PTO.

Comment 7

[Richard Newman [:rnewman]]

Yes, see "ideally" in Comment 2!

I encourage follow-ups.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.