104866 - Non-plugin np*.dll in the plugins folder crashes the browser

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Alvin Thompson]

started between 11 oct and 12 oct builds.

when entering sites created with Microsoft's newer backend stuff, and with
Microsoft's 'npptools.dll' installed, browser crashes.


Reproducible: Always
Steps to Reproduce:
1. have a program install 'npptools.dll' in plugin dir or install it yourself.
2. go to www.espn.com
3! broswer crashes

Comment 1

[Alvin Thompson]

Attachment: npptools.dll

Comment 2

[Matthias Versen [:Matti]]

-> Plugins

Comment 3

[av (gone)]

It eventually crashes on nsCRT::strlen(aANSIString); when the argument is null. 
This thing itself may be a bug -- nsCRT should probably not crash in situations 
like this.

Our problem is different. The attached file -- npptools.dll -- is _not_ a 
plugin. Its version stamp lacks everything we need to consider the dll a plugin, 
it does not even specify the mime type is supposed to handle. So the temptation 
is to declare the bug invalid but on the second thought I think we still have a 
valid bug here. Mozilla currently includes every dll it founds in the plugins 
folder which name starts with np* into its plugin list. This is wrong. We should 
at least check for the presense of mime type. Changing summary.

The crash should be fixed anyway. Filtering dll's is the next step. We should 
probably file a bug on this.

Comment 4

[av (gone)]

Attachment: patch to fix the crash -- first try

Comment 5

[av (gone)]

nhotta, would you please review? This patch changes the code you recently wrote.

Comment 6

[nhottanscp]

Comment on attachment 53652 [details] [diff] [review]
patch to fix the crash -- first try

r=nhotta

Comment 7

[Chris Waterson]

Comment on attachment 53652 [details] [diff] [review]
patch to fix the crash -- first try

sr=waterson

Comment 8

[av (gone)]

Checked in.

Comment 9

[shrirang khanzode]

verif fixed on win98 ...trunk 1107 build.