Log a message on startup when chaos mode is enabled

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

unspecified
mozilla35
x86_64
Linux
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I enabled chaos mode, but after a suspiciously quick rebuild, I wasn't sure if I screwed something up or not.  So this patch logs a (cheesy) message on startup if chaos mode is on.
Attachment #8467543 - Flags: review?(jmathies)
Comment on attachment 8467543 [details] [diff] [review]
Log a message on startup when chaos mode is enabled.

Review of attachment 8467543 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +2851,5 @@
>  
>    StartupTimeline::Record(StartupTimeline::MAIN);
>  
> +  if (ChaosMode::isActive()) {
> +    printf_stderr("[ [ [ [ [    C H A O S    M O D E    ] ] ] ] ]\n");

nit - a wee bit obnoxious, you might want to tone the message down. Something more simplistic like

"*** You are running in chaos test mode. See ChaosMode.h. ***"
Attachment #8467543 - Flags: review?(jmathies) → review+
Thanks for the quick review!  I haven't had a chance to get back to this lately, but will address your comment when I do.
Changed message, carrying r=jimm.
Attachment #8467543 - Attachment is obsolete: true
Attachment #8491676 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f03f4456e789
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.