1048706 - Log a message on startup when chaos mode is enabled

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Log a message on startup when chaos mode is enabled.

I enabled chaos mode, but after a suspiciously quick rebuild, I wasn't sure if I screwed something up or not.  So this patch logs a (cheesy) message on startup if chaos mode is on.

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 8467543 [details] [diff] [review]
Log a message on startup when chaos mode is enabled.

Review of attachment 8467543 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/nsAppRunner.cpp
@@ +2851,5 @@
>  
>    StartupTimeline::Record(StartupTimeline::MAIN);
>  
> +  if (ChaosMode::isActive()) {
> +    printf_stderr("[ [ [ [ [    C H A O S    M O D E    ] ] ] ] ]\n");

nit - a wee bit obnoxious, you might want to tone the message down. Something more simplistic like

"*** You are running in chaos test mode. See ChaosMode.h. ***"

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Thanks for the quick review!  I haven't had a chance to get back to this lately, but will address your comment when I do.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Log a message on startup when chaos mode is enabled, v2

Changed message, carrying r=jimm.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f03f4456e789

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f03f4456e789