[spartacus] REAUTH timeout can be shown post a success re-auth.

RESOLVED FIXED in 2014-08-12

Status

P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: scolville, Assigned: scolville)

Tracking

Avenir
2014-08-12
x86
Mac OS X
Points:
---

Details

(Whiteboard: [qa-])

If the timeout fires because the user takes a long time to re-auth the user sees the REAUTH_TIMEOUT message briefly before the handlePersonaLogin event fires. This is probably for the duration that the verification takes.

To fix this we probably just need to add a app.error.close() in the handlePersonaLogin handler.
Assignee: nobody → scolville
https://github.com/mozilla/spartacus/commit/ccfd5adfce50e76c052c2e011335e44842cac8ae
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2014-08-12
Priority: -- → P3
This worked but then the sign-in window was also revealed. So instead of the app.error.close() we need to show a throbber which will close the error *and* show a throbber whilst the re-verification process happens.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
s/sign-in window/sign-in view/
https://github.com/mozilla/spartacus/commit/f5f200fd2874c77c838f99173560829498ab2c23
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.