Experiment with django_filter in /betasearch

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
a year ago

People

(Reporter: giorgos, Unassigned)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [kb=1469168] [Triage 2015-04-17])

(Reporter)

Description

4 years ago
With bug 1029454 we created a /betasearch view behind waffle. 

This bug is about altering and enhancing the search code with the django_filters package [0] to allow users to free text search and/or limit by groups, skills, timezone and other profile data.

After evaluating the results of the experiment, new bugs will be filled to move code to the normal /search view

[0] https://django-filter.readthedocs.org/en/latest/
(Reporter)

Updated

4 years ago
Assignee: nobody → chromano
Status: NEW → ASSIGNED

Comment 1

4 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d66031320ad851069486612124be790ff3be2ccc
[Bug 1048844] Implement vouched filter in /betasearch using django-filter.

https://github.com/mozilla/mozillians/commit/879707bcf98e503d9a06bb428eebfd50547408e6
[bug 1048844] Add skills, groups, timezone filtering in /betasearch.
(Reporter)

Comment 2

4 years ago
OK the /betasearch page now uses django-filter and we also have a
few filters for demo. 

Further steps:
 - Expand to more filters, like country, external accounts, etc
 - Improve the UI: We currently use a hidden div with all the filters. 
   - Let's make this beautiful
   - Let's make this visible on load when there are search filters in place.
 - We can always explore more, like on-the-fly updates of the results.
(Reporter)

Comment 3

4 years ago
Chromano are you interested to continue working on this? If yes that are your opinions about comment #2?
Flags: needinfo?(chromano)
(In reply to Giorgos Logiotatidis [:giorgos] (afk Aug 11-20) from comment #3)
> Chromano are you interested to continue working on this? If yes that are
> your opinions about comment #2?

Yep, I`m interested.  Regarding the UI, I think it would make sense to let the users add as many filters as they want instead of cluttering the interface with lots of options to choose from.  I will implement my idea then we can discuss on it, thoughts?
Flags: needinfo?(chromano)
Whiteboard: [kb=1469168]
A couple of thoughts regarding /betasearch UI:

* For fields like skills and groups that have many entries, we can experiment with some kind of auto completion.

* We can show an overview of the fields we are filtering our results near "search" field, with a small `x` button in case user wants to revert that filter to it's default value.

:chromano
If you think you are ready to implement your idea, I suggest to go for it and then discuss for further enhancements. Also, if it works for you, we can start tracking /betasearch with a tracker bug blocked by new features/enhancements.
Flags: needinfo?(chromano)
See Also: → bug 1058646
Changing status due to inactivity.
Assignee: chromano → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(chromano)
Whiteboard: [kb=1469168] → [kb=1469168] [Triage 2015-04-17]
(Reporter)

Comment 7

3 years ago
Hey :chromano you pinged me the other day. Are you still up for this bug?
Flags: needinfo?(chromano)
(In reply to Giorgos Logiotatidis [:giorgos] from comment #7)
> Hey :chromano you pinged me the other day. Are you still up for this bug?

Yeap, I will have more time during the end of the week/weekend to work on it, you can expect a patch by then. Thanks! :)
Hey :chromano, since there is long time since your last activity regarding /betasearch would you like to catch up on IRC (#commtools) regarding any further changes? Teams have changed so i am not sure that the rest of the current members are informed about this effort.
(Reporter)

Updated

2 years ago
Flags: needinfo?(chromano)
The django_filter experiment has been removed from mozillians.org as part of the search refactor (django-haystack). I am marking this bug as wontfix.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.