upgradeCleanup() should happen before AddDirs

VERIFIED FIXED in mozilla0.9.7

Status

SeaMonkey
Installer
VERIFIED FIXED
17 years ago
14 years ago

People

(Reporter: Curt Patrick (gone), Assigned: Curt Patrick (gone))

Tracking

Trunk
mozilla0.9.7
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
We want to clean up obsolete files before we start adding new stuff just in case
we eventually add a file back in that has the same name as an obsolete file
we're removing.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

17 years ago
Sean put some notes in bugscape bug number 9941 that explain this further.
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.6
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.6 → mozilla0.9.7
(Assignee)

Comment 2

17 years ago
Created attachment 56031 [details] [diff] [review]
For ns
(Assignee)

Comment 3

17 years ago
Created attachment 56033 [details] [diff] [review]
for mozilla

Comment 4

17 years ago
Comment on attachment 56031 [details] [diff] [review]
For ns

r=ssu
Attachment #56031 - Flags: review+

Comment 5

17 years ago
Comment on attachment 56033 [details] [diff] [review]
for mozilla

r=ssu
Attachment #56033 - Flags: review+
Attachment #56031 - Flags: superreview+
Why would we ever delete a file that we're just going to replace? I agree,
though, that if we ever do such a silly thing then this order is much safer.

sr=dveditz
Attachment #56033 - Flags: superreview+
(Assignee)

Comment 7

17 years ago
The fix is checked in to mozilla and ns trunk.

Just as a record of our thinking, it might be that a file witht he same name as
an obsolete file we are deleting might get reintroduced and the odds are good
that noone would catch the fact that it is being deleted.  That is at least one
scenerio under which we might do this silly thing.  So this just plays it safe.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
verified code fixes-upgradecleanup before add dirs
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.