1048923 - SIMD: Tidy up SIMD.{h,cpp} and better handle unary binary functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Rename js::Create into js::CreateSimd

This patch renames js::Create<SimdType> into js::CreateSimd<SimdType>, as
asked in the SIMD odin bug.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Use helpers in GetLane

GetLane can actually take advantage of those helpers introduced in a former
patch.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Create StoreResult helper and make use of it

Another helper that creates the result object and stores it in args.rval().
Easy tidying up.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Distinguish unary and binary SIMD functions

The fact that unary and binary SIMD functions are handled the same way makes it
quite difficult to specialize for the number of arguments, leading to weird
possible uses. For instance, one can call an unary SIMD operator with two
arguments, and the second will be ignored. More fancy: one can also call a
binary SIMD op with only argument, and in this case the second argument will be
0 by default.

var x = SIMD.float32x4(1,2,3,4);
SIMD.float32x4.add(x); // returns x
SIMD.float32x4.mul(x); // returns 0 x 4
SIMD.float32x4.div(x); // returns Infinity x 4

Let's just split the logic into two functions, that makes it easier to follow
and less error prone.

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Remove unused MIRFlag macro in SIMD functions list

The last macro param in the functions list isn't used and probably won't be.

Comment 6

[Luke Wagner [:luke]]

Comment on attachment 8467808 [details] [diff] [review]
Rename js::Create into js::CreateSimd

Review of attachment 8467808 [details] [diff] [review]:
-----------------------------------------------------------------

As mentioned in bug 992267, perhaps we can standardize on "SIMD" instead of "Simd".

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Part 1: (we agreed on keeping on using the Simd form, to avoid forms like AsmJSSIMDSomething)
https://hg.mozilla.org/integration/mozilla-inbound/rev/044f81a162bf

Comment 8

[Niko Matsakis [:nmatsakis]]

Comment on attachment 8467809 [details] [diff] [review]
Use helpers in GetLane

Review of attachment 8467809 [details] [diff] [review]:
-----------------------------------------------------------------

Hard to object to this!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/044f81a162bf

Comment 10

[Benjamin Bouvier [:bbouvier] (inactive)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1c1ddbed35d7
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7f319e5651ab
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/52887ebdde3f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c46b85ce3816

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c1ddbed35d7
https://hg.mozilla.org/mozilla-central/rev/7f319e5651ab
https://hg.mozilla.org/mozilla-central/rev/52887ebdde3f
https://hg.mozilla.org/mozilla-central/rev/c46b85ce3816