1048941 - Make all empty view images 90x90dp

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[:Margaret Leibovic]

Follow-up to bug 1046579.

ibarlow, could you get me a 90x90 version of this image?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-mdpi/icon_home_empty_firefox.png

Comment 1

[Ian Barlow (:ibarlow)]

Yep, here you go Margaret. http://cl.ly/333b0n0y322I

Comment 2

[:Margaret Leibovic]

Attachment: Make all empty view images 90x90dp

This was actually really simple, so maybe we should consider just uplifting this instead of bug 1046579.

However, I just tried testing this with an add-on that specifies its own empty view image, and it always fails to load. The same issue seems to be present in release, so maybe we broke something along the way? I'll file a separate bug for this.

Comment 3

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #2)

> However, I just tried testing this with an add-on that specifies its own
> empty view image, and it always fails to load. The same issue seems to be
> present in release, so maybe we broke something along the way? I'll file a
> separate bug for this.

Nevermind! There was a bug in my add-on :)

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8469349 [details] [diff] [review]
Make all empty view images 90x90dp

Review of attachment 8469349 [details] [diff] [review]:
-----------------------------------------------------------------

Good.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/d4a83ef83da1

Comment 6

[:Margaret Leibovic]

I updated the docs here:
https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Home.jsm/panels#Empty_view_options

Currently on release we don't scale the images at all, so if an add-on author supplies a 90dp image, the right thing will happen.

I want to uplift this patch instead of the patch for bug 1046579. I'll attach a rebased patch for aurora/beta.

Comment 7

[:Margaret Leibovic]

Attachment: patch for uplift

Approval Request Comment
[Feature/regressing bug #]: bug 996708 and bug 1023914
[User impact if declined]: empty view images on about:home will be scaled badly
[Describe test coverage new/current, TBPL]: no automated tests, tested locally and just landed on fx-team
[Risks and why]: low-risk, this change only affects these empty views (e.g. when the user has no bookmarks or history)
[String/UUID change made/needed]: none

Comment 8

[:Margaret Leibovic]

Setting tracking to 32, since uplifting this will address the issue in bug 1046579.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d4a83ef83da1

Comment 10

[Aaron Train [:aaronmt]]

I can't tell the difference with my eyes, but I do see the same resources in the ImageViews used

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/95776d575df5

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8471050 [details] [diff] [review]
patch for uplift

Looks like a simple enough change. beta+

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/511ac00e4e6c

Comment 14

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Build: Firefox for Android 33.0a2 (2014-08-17)
Device: Asus Transformer Pad TF300T (Android 4.2.1)

Comment 15

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Build: Firefox for Android 32 Beta 8
Device: Asus Transformer Pad TF300T (Android 4.2.1)