Closed Bug 1048941 Opened 5 years ago Closed 5 years ago

Make all empty view images 90x90dp

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox32 --- verified
firefox33 --- verified
firefox34 --- verified
fennec 32+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(2 files)

Follow-up to bug 1046579.

ibarlow, could you get me a 90x90 version of this image?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-mdpi/icon_home_empty_firefox.png
Flags: needinfo?(ibarlow)
Yep, here you go Margaret. http://cl.ly/333b0n0y322I
Flags: needinfo?(ibarlow)
This was actually really simple, so maybe we should consider just uplifting this instead of bug 1046579.

However, I just tried testing this with an add-on that specifies its own empty view image, and it always fails to load. The same issue seems to be present in release, so maybe we broke something along the way? I'll file a separate bug for this.
Attachment #8469349 - Flags: review?(lucasr.at.mozilla)
(In reply to :Margaret Leibovic from comment #2)

> However, I just tried testing this with an add-on that specifies its own
> empty view image, and it always fails to load. The same issue seems to be
> present in release, so maybe we broke something along the way? I'll file a
> separate bug for this.

Nevermind! There was a bug in my add-on :)
Comment on attachment 8469349 [details] [diff] [review]
Make all empty view images 90x90dp

Review of attachment 8469349 [details] [diff] [review]:
-----------------------------------------------------------------

Good.
Attachment #8469349 - Flags: review?(lucasr.at.mozilla) → review+
I updated the docs here:
https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Home.jsm/panels#Empty_view_options

Currently on release we don't scale the images at all, so if an add-on author supplies a 90dp image, the right thing will happen.

I want to uplift this patch instead of the patch for bug 1046579. I'll attach a rebased patch for aurora/beta.
Attached patch patch for upliftSplinter Review
Approval Request Comment
[Feature/regressing bug #]: bug 996708 and bug 1023914
[User impact if declined]: empty view images on about:home will be scaled badly
[Describe test coverage new/current, TBPL]: no automated tests, tested locally and just landed on fx-team
[Risks and why]: low-risk, this change only affects these empty views (e.g. when the user has no bookmarks or history)
[String/UUID change made/needed]: none
Attachment #8471050 - Flags: approval-mozilla-beta?
Attachment #8471050 - Flags: approval-mozilla-aurora?
Setting tracking to 32, since uplifting this will address the issue in bug 1046579.
tracking-fennec: --- → 32+
https://hg.mozilla.org/mozilla-central/rev/d4a83ef83da1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Flags: needinfo?(aaron.train)
Keywords: verifyme
Attachment #8471050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I can't tell the difference with my eyes, but I do see the same resources in the ImageViews used
Status: RESOLVED → VERIFIED
Flags: needinfo?(aaron.train)
Comment on attachment 8471050 [details] [diff] [review]
patch for uplift

Looks like a simple enough change. beta+
Attachment #8471050 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed in:
Build: Firefox for Android 33.0a2 (2014-08-17)
Device: Asus Transformer Pad TF300T (Android 4.2.1)
Verified as fixed in
Build: Firefox for Android 32 Beta 8
Device: Asus Transformer Pad TF300T (Android 4.2.1)
You need to log in before you can comment on or make changes to this bug.