1048967 - Allow version info to run from any directory

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Armen [:armenzg]]

Attachment: changelog.diff

If I'm inside of mozdevice, then it tries to run hg log mozdevice/setup.py ... which is a non-existent file from my current working directory.

This patch does the trick.

Comment 1

[Andrew Halberstadt [:ahal]]

Comment on attachment 8467858 [details] [diff] [review]
changelog.diff

Review of attachment 8467858 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just a couple of optional comments. Thanks!

::: testing/mozbase/versioninfo.py
@@ +94,5 @@
>  
>  
>  def main(args=sys.argv[1:]):
> +    abspath = os.path.abspath(__file__)
> +    dname = os.path.dirname(abspath)

This is fine, but just fyi a common convention we use throughout many of our automation files is to put:

here = os.path.abspath(os.path.dirname(__file__))

at the top of the file.

@@ +95,5 @@
>  
>  def main(args=sys.argv[1:]):
> +    abspath = os.path.abspath(__file__)
> +    dname = os.path.dirname(abspath)
> +    os.chdir(dname)

Instead of os.chdir, I would probably pass it in to the subprocess.check_output call via the 'cwd' parameter.

Comment 2

[Armen [:armenzg]]

Addressed comments and landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc1fd2a2818

Thanks ahal.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9fc1fd2a2818