1048991 - Home button on search screen should take you back to homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Botond Ballo [:botond]]

STR:
  1. Go to homescreen.
  2. Tap the search bar, activating the search screen.
  3. Press the home button.

Expected results:
  You are taken back to the homescreen.

Actual results:
  Pressing the home button has no effect.
  You have to press 'close' to go back to the homescreen.

Tested with recent master on a Flame device.

Comment 1

[Chris Lord [:cwiiis]]

Happens here too... This sounds like a bug. Cc'ing some people to see if it's intended behaviour, but I don't imagine it is.

Comment 2

[Gregor Wagner [:gwagner]]

I noticed this as well. Francis, I assume we should go back to the homescreen?

Comment 3

[Kevin Grandon :kgrandon]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> I noticed this as well. Francis, I assume we should go back to the
> homescreen?

Yeah, this is a regression from bug 1045758. The root cause is that we did not have 'home' handling in the rocketbar originally, so we missed it as we combined the two files. Should be a fairly trivial fix, so I'll take it.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey - Dale/Vivien, either of you guys have time for a review? Thanks!

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8467911 [details] [review]
Github pull request

Or Francisco - since we're sitting in Rocketbar office hours right now, maybe you could review this? Thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8467911 [details] [review]
Github pull request

Pretty, clean and simple.

Tested on the device and working perfectly.

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8467911 [details] [review]
Github pull request

Thanks Francisco! Let's go with your review for now.

Comment 8

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/18b405f6017a09aafd3d967249de885d32ed797a

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Set this fixed regression to block because of bug 1048777.

Comment 10

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb) and the Flame 2.2 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Result: User is taken back to the homescreen, when tapping the homescreen button

Comment 11

[Kevin Grandon :kgrandon]

Attachment: Pull request - marionette test follow-up

Dale could you give this a quick review? Thanks!

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 8510465 [details] [review]
Pull request - marionette test follow-up

Looks good, thanks

Comment 13

[Dale Harvey (:daleharvey)]

I triggered another run of Gij3, may need a rebase though

Comment 14

[Kevin Grandon :kgrandon]

Thanks Dale! Landed test in master: https://github.com/mozilla-b2g/gaia/commit/bd7a73c1f1d8211deb95543e9e14a5eeef36d5e1