Closed
Bug 1049011
Opened 10 years ago
Closed 10 years ago
remove asterisks. indicate optional fields instead.
Categories
(Marketplace Graveyard :: Curation Tools, defect, P5)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: krupa.mozbugs, Assigned: chuck)
References
()
Details
Attachments
(1 file)
29.03 KB,
image/png
|
Details |
steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/create/shelves
2. Notice that certain field labels have an asterisk next to them
expected behavior:
We explain what the asterisk means, in this case it indicates that the field is required
actual behavior:
No explanation provided for the asterisks
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → charmston
Comment 1•10 years ago
|
||
Chuck, since we only have like one optional field (Description), we should just mark the optional fields.
https://medium.com/the-hitchhikers-guide-to-the-web/why-you-should-avoid-using-red-asterisks-12015ba2fab3
Assignee: charmston → nobody
Updated•10 years ago
|
Assignee: nobody → charmston
Updated•10 years ago
|
Summary: Indicate what the asterisks mean → remove asterisks. indicate optional fields instead.
Assignee | ||
Comment 2•10 years ago
|
||
Philip, what would you prescribe here? Italic/lighter gray for optional fields?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(pwalmsley)
Comment 3•10 years ago
|
||
I propose just append "(optional)" to optional fields.
Comment 4•10 years ago
|
||
Agreed with @ngoke. Mark the optional fields as such, and alert them with an error field when something is entered incorrectly.
https://dl.dropboxusercontent.com/u/545688/mozilla/Screen%20Shot%202014-08-14%20at%2010.55.00%20AM.png
Text should be set in the body style: http://pwalm.github.io/marketplace-style-guides/type.html
Flags: needinfo?(pwalmsley)
Updated•10 years ago
|
Priority: P4 → P5
Assignee | ||
Comment 5•10 years ago
|
||
For a number of reasons, the placeholder text is a bad place to put required/optional information:
- Accessibility-wise, no screen reader will pick up on that text (admittedly the current solution isn't great here, but it's better).
- Sometimes this text will be misleading, because of the way we do localized fields. For example, if you provide an English language translation of a collection name and switch to another language, it would be completely valid to submit without a name for the secondary language (which would fall back to English), but it would not indicate that it was optional.
- That information gets lost if text is entered in the field.
I'm going to put it in the help text, as shown in the screenshot. Any objections, Philip?
Flags: needinfo?(pwalmsley)
Comment 6•10 years ago
|
||
This works for me! I had no idea screen readers couldn't pick up on that text. Thanks guys.
Flags: needinfo?(pwalmsley)
Assignee | ||
Comment 7•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•