Closed Bug 1049034 Opened 10 years ago Closed 10 years ago

[feed] hash the feed brand type + layout to give it a consistent color

Categories

(Marketplace Graveyard :: Curation Tools, defect, P4)

Product:
Marketplace Graveyard
Component:
Curation Tools
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kngo, Assigned: chuck)

References

(
URL
)

Details

Every page refresh on the consumer pages, and every preview refresh in the curation tools gives the editorial brands a different color. We can hash the feed brand type + layout or something to give it a "consistently random" color.
No longer depends on: 1049011
The random-per-reload was requested by pwalm. Philip, does consistently random sound like an improvement to you?
Flags: needinfo?(pwalmsley)
I would have to say no. I'd like to keep these colours separate from meaning anything (blue = sports, for example). Random is preferred, so the feed feels lively and colourful and avoids becoming monotone.
Flags: needinfo?(pwalmsley)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
It would still be random, what Kevin is proposing here is that we fix the randomness so that the same item doesn't change on every reload. Does that make sense?
Flags: needinfo?(pwalmsley)
Oh, yes that makes more sense. Yeah, do that! :D Thanks guys
Flags: needinfo?(pwalmsley)
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee: nobody → charmston
https://github.com/mozilla/fireplace/pull/551
https://github.com/mozilla/transonic/compare/2c01ff1c4d34...aa755e14629a
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Implementation note: the color will change whenever the title of or apps in the brand are changed.
You need to log in before you can comment on or make changes to this bug.