Closed Bug 1049143 Opened 5 years ago Closed 5 years ago

Intermittent failing test, TEST-UNEXPECTED-FAIL | /builds/slave/test/gaia/apps/search/test/marionette/places_search_test.js | Places tests Test url searching

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: kgrandon, Assigned: daleharvey)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

Places tests Test url searching:
13:24:12     INFO -    AssertionError: 1 == 0
13:24:12     INFO -        at Context.<anonymous> (/builds/slave/test/gaia/apps/search/test/marionette/places_search_test.js:92:12)
13:24:12     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:223:21)
13:24:12     INFO -        at Test.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
13:24:12     INFO -        at Runner.runTest (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:373:10)
13:24:12     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:451:12
13:24:12     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:298:14)
13:24:12     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:308:7
13:24:12     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:246:23)
13:24:12     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
13:24:12     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
13:24:12     INFO -        at callFn (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:228:7)
13:24:12     INFO -        at Hook.Runnable.run (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:216:7)
13:24:12     INFO -        at next (/builds/slave/test/gaia/node_modules/mocha/lib/runner.js:258:10)
13:24:12     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runner.js:270:7
13:24:12     INFO -        at done (/builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:185:5)
13:24:12     INFO -        at /builds/slave/test/gaia/node_modules/mocha/lib/runnable.js:199:9
13:24:12     INFO -        at Object.executeHook (/builds/slave/test/gaia/node_modules/marionette-client/lib/marionette/client.js:369:18)
13:24:12     INFO -        at process._tickCallback (node.js:415:13)
13:24:12     INFO -  make: *** [test-integration-test] Error 1
13:24:12    ERROR - Return code: 2
13:24:12     INFO - TinderboxPrint: gaia-integration-tests: 254/<em class="testfail">1</em>/48
13:24:12    ERROR - Tests exited with return code 2: harness failures

https://tbpl.mozilla.org/php/getParsedLog.php?id=45271105&tree=B2g-Inbound
This would have caught the regression
Assignee: nobody → dale
Whiteboard: [systemsfe]
As mentioned before, fairly stuck on figuring out how web components are completely broken in this tests, can test with |VERBOSE=1 TEST_FILES=apps/search/test/marionette/places_search_test.js make test-integration|
Flags: needinfo?(kgrandon)
Ok, I will start to take a look. Try not to let this block you if you can avoid it. I wonder if we can leverage the search landing page to test places for the meantime? (Obviously we want both places to have these tests)
Its not blocking me anymore, but this seems like a fairly important test to make sure its enabled
Attached file Github pull request (obsolete) —
So I wasn't able to reproduce any problems with the web components. Have you tried running a make really-clean to clean everything and try again?

I'm submitting this with a simple waitFor() fix to see if we can at least re-enable this one test.
Flags: needinfo?(kgrandon)
Investigating why the last part was flakey, but these are important tests to have and working on adding to them

Got a run with a bunch of greens https://tbpl.mozilla.org/?tree=Gaia-Try&rev=8b4277ad7ea9 (I was only testing places_test.js)
Attachment #8476129 - Attachment is obsolete: true
Attachment #8477620 - Flags: review?(kgrandon)
Comment on attachment 8477620 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23218

Nice job on the green runs. Thanks!
Attachment #8477620 - Flags: review?(kgrandon) → review+
Fixed nits

https://github.com/mozilla-b2g/gaia/commit/917c28c1c2b5991278bbd836d661d20311a9df74
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.