Feed preview for Listing collections is incorrect

VERIFIED FIXED

Status

P1
major
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: krupa.mozbugs, Assigned: kngo)

Tracking

x86
Gonk (Firefox OS)
Points:
---

Details

(URL)

(Reporter)

Description

5 years ago
steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/manage/collections/this-is-a-listing-collection
2. Notice the Feed preview


expected behavior:
As per the spec - 
"Feed representation:
Begins with the Header
Apps are displayed up to 6 (if icon layout) or 3 (if list layout); if there are more apps, a View All link is displayed, which links to the Collection’s detail page."

So, in the feed view, we should be listing 3 or 6 apps like we do for Editorial brands.

actual behavior:
We don't show apps in the feed preview at all (much like Promo collection)

reproducible? 100%
(Assignee)

Comment 1

5 years ago
Well...this is a pretty big mistake.

Our listing collection representation was incorrect this whole time. This will require rework in all portions of the Feed.

- Need to add the frontend for a listing collection, which is like an editorial brand.
- We need to store the type of the collection in the DB.
- Add the type to the indexers, serializers.
- Need to serialize apps for listing collections now.

Davor should start with the listing collection frontend. You can develop either with flue, or with Transonic. But expect collection.type == 'listing'. I'll work on getting the type of the collection stored.
Assignee: nobody → dspasovski
Severity: normal → major
Priority: -- → P1
(Assignee)

Comment 2

5 years ago
Actually, I'm almost done banging it out.
Assignee: dspasovski → kngo
(Reporter)

Comment 4

5 years ago
I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1050946 to show the View All link. But everything mostly matches the spec

verified fixed at https://marketplace-dev.allizom.org/curate/manage/collections/this-is-a-listing-collection
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.