TEST-UNEXPECTED-FAIL | page-mod-debugger-post/main.testDebugger | Test timed out | Should not be any unexpected tabs open

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: KWierso, Assigned: fitzgen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
+++ This bug was initially created as a clone of Bug #1042976 +++

https://tbpl.mozilla.org/php/getParsedLTEST-START | page-mod-debugger-post/main.testDebugger
TEST-PASS | page-mod-debugger-post/main.testDebugger | starting test
TEST-PASS | page-mod-debugger-post/main.testDebugger | tab loaded
TEST-PASS | page-mod-debugger-post/main.testDebugger | attachTabActorForUrl called
TEST-PASS | page-mod-debugger-post/main.testDebugger | Pause wasn't called before we've attached.
TEST-PASS | page-mod-debugger-post/main.testDebugger | aGrip existss
TEST-PASS | page-mod-debugger-post/main.testDebugger | the page-mod was attached to resource://test-page-mod-debugger-at-jetpack/page-mod-debugger-post/data/index.html
TEST-PASS | page-mod-debugger-post/main.testDebugger | PageMod was created
TEST-PASS | page-mod-debugger-post/main.testDebugger | called runDebuggerStatement
1407250508848	GMPInstallManager.simpleCheckAndInstall	INFO	Last check was: 1407250509 seconds ago, minimum seconds: 86400
1407250508849	GMPInstallManager._getURL	INFO	Using url: https://aus4.mozilla.org/update/3/GMP/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
1407250508850	GMPInstallManager._getURL	INFO	Using url (with replacement): https://aus4.mozilla.org/update/3/GMP/34.0a1/20140804190914/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/default/Darwin%2010.8.0/default/default/update.xml
1407250508852	GMPInstallManager.checkForAddons	INFO	sending request to: https://aus4.mozilla.org/update/3/GMP/34.0a1/20140804190914/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/default/Darwin%2010.8.0/default/default/update.xml
1407250508944	GMPInstallManager.onLoadXML	INFO	request completed downloading document
1407250508945	GMPInstallManager.onLoadXML	INFO	allowNonBuiltIn: false
1407250508957	GMPInstallManager.simpleCheckAndInstall	INFO	Found 1 addons advertised.
1407250508957	GMPInstallManager.simpleCheckAndInstall	INFO	Found addon: gmp-gmpopenh264 (isValid: true, isInstalled: false, isOpenH264: true, hashFunction: SHA512, hashValue: 0eac05de3b9dd939ece57450bcddf6fee04415a99744a0ce46ddb19c1205cbaf4d8c5a7b5efc2158c9fb257a7948024ed1604890b56382513922107e22273165, size: 282746)
1407250509031	GMPInstallManager.simpleCheckAndInstall	INFO	Addon installed successfully: gmp-gmpopenh264 (isValid: true, isInstalled: true, isOpenH264: true, hashFunction: SHA512, hashValue: 0eac05de3b9dd939ece57450bcddf6fee04415a99744a0ce46ddb19c1205cbaf4d8c5a7b5efc2158c9fb257a7948024ed1604890b56382513922107e22273165, size: 282746)
TEST-INFO | [JavaScript Error: "Error adding value null to histogram PLACES_ANNOS_PAGES_SIZE_KB: Error: Not a number" {file: "resource://gre/modules/PlacesDBUtils.jsm" line: 1018}]
TEST-UNEXPECTED-FAIL | page-mod-debugger-post/main.testDebugger | Test timed out
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 454, in tiredOfWaiting
    self.console.testMessage(false, false, self.test.name, "Test timed out");
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/test/harness.js", line 527, in testMessage
    this.trace();
TEST-UNEXPECTED-FAIL | page-mod-debugger-post/main.testDebugger | Should not be any unexpected tabs open
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/Promise-backend.js", line 745, in this.PromiseWalker.walkerLoop
    this.handlers.shift().process();
  File "resource://gre/modules/Promise-backend.js", line 866, in Handler.prototype.process
    nextValue = this.onResolve.call(undefined, nextValue);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 313, in done/<
    this.fail("Should not be any unexpected tabs open");
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 88, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/test/harness.js", line 527, in testMessage
    this.trace();
TEST-INFO | Windows open:
TEST-INFO | chrome://browser/content/browser.xul - about:blank, resource://test-page-mod-debugger-at-jetpack/page-mod-debugger-post/data/index.html
TEST-END | page-mod-debugger-post/main.testDebuggerog.php?id=45250907&tree=Jetpack



TEST-START | page-mod-debugger-pre/main.testDebugger
TEST-PASS | page-mod-debugger-pre/main.testDebugger | starting test
TEST-PASS | page-mod-debugger-pre/main.testDebugger | PageMod was created
TEST-PASS | page-mod-debugger-pre/main.testDebugger | tab loaded
TEST-PASS | page-mod-debugger-pre/main.testDebugger | attachTabActorForUrl called
TEST-PASS | page-mod-debugger-pre/main.testDebugger | Pause wasn't called before we've attached.
TEST-PASS | page-mod-debugger-pre/main.testDebugger | aGrip existss
TEST-PASS | page-mod-debugger-pre/main.testDebugger | called runDebuggerStatement
1407250812590	GMPInstallManager.simpleCheckAndInstall	INFO	Last check was: 1407250813 seconds ago, minimum seconds: 86400
1407250812590	GMPInstallManager._getURL	INFO	Using url: https://aus4.mozilla.org/update/3/GMP/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
1407250812591	GMPInstallManager._getURL	INFO	Using url (with replacement): https://aus4.mozilla.org/update/3/GMP/34.0a1/20140804190914/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/default/Darwin%2010.8.0/default/default/update.xml
1407250812593	GMPInstallManager.checkForAddons	INFO	sending request to: https://aus4.mozilla.org/update/3/GMP/34.0a1/20140804190914/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/default/Darwin%2010.8.0/default/default/update.xml
1407250812688	GMPInstallManager.onLoadXML	INFO	request completed downloading document
1407250812689	GMPInstallManager.onLoadXML	INFO	allowNonBuiltIn: false
1407250812702	GMPInstallManager.simpleCheckAndInstall	INFO	Found 1 addons advertised.
1407250812702	GMPInstallManager.simpleCheckAndInstall	INFO	Found addon: gmp-gmpopenh264 (isValid: true, isInstalled: false, isOpenH264: true, hashFunction: SHA512, hashValue: 0eac05de3b9dd939ece57450bcddf6fee04415a99744a0ce46ddb19c1205cbaf4d8c5a7b5efc2158c9fb257a7948024ed1604890b56382513922107e22273165, size: 282746)
1407250812776	GMPInstallManager.simpleCheckAndInstall	INFO	Addon installed successfully: gmp-gmpopenh264 (isValid: true, isInstalled: true, isOpenH264: true, hashFunction: SHA512, hashValue: 0eac05de3b9dd939ece57450bcddf6fee04415a99744a0ce46ddb19c1205cbaf4d8c5a7b5efc2158c9fb257a7948024ed1604890b56382513922107e22273165, size: 282746)
TEST-INFO | [JavaScript Error: "Error adding value null to histogram PLACES_ANNOS_PAGES_SIZE_KB: Error: Not a number" {file: "resource://gre/modules/PlacesDBUtils.jsm" line: 1018}]
TEST-UNEXPECTED-FAIL | page-mod-debugger-pre/main.testDebugger | Test timed out
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 454, in tiredOfWaiting
    self.console.testMessage(false, false, self.test.name, "Test timed out");
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/test/harness.js", line 527, in testMessage
    this.trace();
TEST-UNEXPECTED-FAIL | page-mod-debugger-pre/main.testDebugger | Should not be any unexpected tabs open
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/Promise-backend.js", line 745, in this.PromiseWalker.walkerLoop
    this.handlers.shift().process();
  File "resource://gre/modules/Promise-backend.js", line 866, in Handler.prototype.process
    nextValue = this.onResolve.call(undefined, nextValue);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 313, in done/<
    this.fail("Should not be any unexpected tabs open");
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 88, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.test-page-mod-debugger-at-jetpack.commonjs.path/sdk/test/harness.js", line 527, in testMessage
    this.trace();
TEST-INFO | Windows open:
TEST-INFO | chrome://browser/content/browser.xul - about:blank, resource://test-page-mod-debugger-at-jetpack/page-mod-debugger-pre/data/index.html
TEST-END | page-mod-debugger-pre/main.testDebugger
(Reporter)

Comment 1

4 years ago
Copying logs over from bug 1042976: 

(In reply to Wes Kocher (:KWierso) from comment #8)
> (In reply to Dave Townsend [:mossop] from comment #7)
> > This test is just timing out now
> 
> This started failing on this push of checkin-needed bugs to fx-team:
> https://tbpl.mozilla.org/?tree=Fx-
> Team&jobname=jetpack&showall=1&rev=fea2a90e2d22
> 
> Gonna guess it's bug 1039952.

(In reply to Nick Fitzgerald [:fitzgen] from comment #9)
> It might be related, as bug 1039952 did change the way that debuggee globals
> are managed by the debugger, which includes the addon debugger. I'm not sure
> what these tests are, or where exactly the test is located. Those files
> linked don't tell me much...
> 
> Mossop, you wrote a lot of the initial addon debugger code surrounding
> finding addon debuggee globals, can you take a look at [0] and see if there
> is anything missing from the original logic?
> 
> [0]
> http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> webbrowser.js#1492

(In reply to Dave Townsend [:mossop] from comment #10)
> This test isn't part of the add-on debugger, it's page-mods showing up in
> the regular webpage debugger I think, that was Erik's work. Erik, how does
> the page-mod globals get added as debuggees?

(In reply to Nick Fitzgerald [:fitzgen] from comment #11)
> In that case, for finding all debuggee globals, we use the parent's
> |windows| getter:
> 
> http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> webbrowser.js#551
> http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> webbrowser.js#635
> 
> And for new globals that pop up while debugging, we check if we should add
> them as a debuggee with this function:
> 
> http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> webbrowser.js#754
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Created attachment 8468797 [details] [diff] [review]
move-getInnerId.patch

No try push because the tree is closed :-/
Attachment #8468797 - Flags: review?(evold)
Priority: -- → P1
Attachment #8468797 - Flags: review?(evold) → review+
Hey Nick, I'm guessing this slipped off your radar? can you push it soon please?
Flags: needinfo?(nfitzgerald)
(Reporter)

Comment 4

4 years ago
I can push this to try once I get the all-clear to reopen try.
(Reporter)

Comment 6

4 years ago
Needinfoing myself to push the patch once the try run finishes up since I think Nick's on PTO this week.
Flags: needinfo?(kwierso)
(Reporter)

Comment 7

4 years ago
So, it looks like this may have fixed two of the failure lines in the Jetpack tests, though I'm still seeing the failure lines from the bug summary once. (Was happening twice per run without this patch.)

I'll leave this for Nick to decide if that's worthy of pushing to fx-team.
Flags: needinfo?(kwierso)
Can someone point me at docs on how to run the jetpack tests? Specifically, just this failing test. The TBPL logs aren't very verbose or useful.
Flags: needinfo?(nfitzgerald)
(In reply to Nick Fitzgerald [:fitzgen] from comment #8)
> Can someone point me at docs on how to run the jetpack tests? Specifically,
> just this failing test. The TBPL logs aren't very verbose or useful.

* from m-c checkout root
cd addon-sdk/source
source bin/activate
cfx testaddons -b path/to/firefox -f page-mod-debugger
Nick any luck?
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(evold)
I'm trying to run the test as you suggested, but it doesn't like my firefox build. I can run this build directly, so it does actually exist.

----------------------------------------------------------------

fitzgen@nfitzgerald-11520 :: (master) :: ~/src/addon-sdk
    $ cfx testaddons -b /Users/fitzgen/src/mozilla-central/obj.noindex/dist/bin/firefox-bin -f page-mod-debugger
Testing page-mod-debugger-post...
Traceback (most recent call last):
  File "/Users/fitzgen/src/addon-sdk/bin/cfx", line 33, in <module>
    cuddlefish.run()
  File "/Users/fitzgen/src/addon-sdk/python-lib/cuddlefish/__init__.py", line 621, in run
    test_all_testaddons(env_root, defaults=options.__dict__)
  File "/Users/fitzgen/src/addon-sdk/python-lib/cuddlefish/__init__.py", line 447, in test_all_testaddons
    env_root=env_root)
  File "/Users/fitzgen/src/addon-sdk/python-lib/cuddlefish/__init__.py", line 949, in run
    no_connections=no_connections)
  File "/Users/fitzgen/src/addon-sdk/python-lib/cuddlefish/runner.py", line 605, in run_app
    kp_kwargs=popen_kwargs)
  File "/Users/fitzgen/src/addon-sdk/python-lib/mozrunner/__init__.py", line 384, in __init__
    raise Exception("Binary path does not exist "+self.binary)
Exception: Binary path does not exist /Users/fitzgen/src/mozilla-central/obj.noindex/dist/bin/firefox-bin/Contents/MacOS/firefox-bin

-----------------------------------------------------------------
Flags: needinfo?(nfitzgerald)
Wait, looks like its appending "/Contents/MacOS/firefox-bin" to my path even though I give it the binary directly.
Blocks: 1039952
Flags: needinfo?(evold)
Looks like this landed in m-c and we never closed this bug.

$ git log --oneline | grep "Part 2: Move getInnerId to actors/webbrowser.js"
15b6a67 Bug 1039952 - Part 2: Move getInnerId to actors/webbrowser.js. r=me
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.