1049244 - Add required MTP extensions for tako device

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: MTP/UMS, defect)

Description

[Dave Hylands [:dhylands]]

Add extensions required for the tako device.

Comment 1

[Eric Chou [:ericchou] [:echou]]

I'll investigate what else we need to do.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Per offline discussion with

Comment 3

[Eric Chou [:ericchou] [:echou]]

ok, I have studied the spec and Android's implementation to see what changes are necessary for
supporting MTP extension. It seems to me that we don't need to do anything in Gecko at this stage. Vendors who want to add MTP extensions can just port what they have done for Android to their Gonk codebase.

First, since we will only support MTP server role, vendors should modify MtpServer.cpp in AOSP[1] to respond with the information of the extension (MTP Vendor Extension ID & MTP extensions string) when the MTP client asks for device information.

After that, vendors need to implement handlers to deal with their customized commands in function MtpServer::handleRequest(). Vendors should be able to do something they want to do (based on the command) in the handler, then respond to the connected MTP client correspondingly.[2]

Please feel free to ask MTP extension related questions here.

[1] http://androidxref.com/source/xref/frameworks/av/media/mtp/MtpServer.cpp#422
[2] http://androidxref.com/source/xref/frameworks/av/media/mtp/MtpServer.cpp#307

Comment 4

[Eric Chou [:ericchou] [:echou]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #3)
> ok, I have studied the spec and Android's implementation to see what changes
> are necessary for
> supporting MTP extension. It seems to me that we don't need to do anything
> in Gecko at this stage. Vendors who want to add MTP extensions can just port
> what they have done for Android to their Gonk codebase.
> 
> First, since we will only support MTP server role, vendors should modify
> MtpServer.cpp in AOSP[1] to respond with the information of the extension
> (MTP Vendor Extension ID & MTP extensions string) when the MTP client asks
> for device information.
> 
> After that, vendors need to implement handlers to deal with their customized
> commands in function MtpServer::handleRequest(). Vendors should be able to
> do something they want to do (based on the command) in the handler, then
> respond to the connected MTP client correspondingly.[2]
> 
> Please feel free to ask MTP extension related questions here.
> 
> [1]
> http://androidxref.com/source/xref/frameworks/av/media/mtp/MtpServer.cpp#422
> [2]
> http://androidxref.com/source/xref/frameworks/av/media/mtp/MtpServer.cpp#307

Per offline discussion, the implementation that we currently have is enough for adding extensions. I'll leave this open until the feature gets resolved so that we can have a platform to answer more questions.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Remove myself from the assignee per comment 4.

Comment 6

[Ben Tian (inactive)]

Alphan, is this bug tako-specific or general? Please mark as wontfix if it's tako-specific.

Comment 7

[Alphan Chen [:alchen]]

Since it is a requirement for tako (status:suspend), I make this bug as WONTFIX.