Closed Bug 1049249 Opened 9 years ago Closed 9 years ago

Remove app_libxul_dirs

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Remove app_libxul_dirs
4.73 KB, patch
mshal
: review+
Details | Diff | Splinter Review
Remove app_libxul_dirs from c-c
3.33 KB, patch
jcranmer
: review+
Details | Diff | Splinter Review 
It was used to force building components after libxul. That's not necessary anymore with USE_LIBS \o/
Depends on: 1049247
(In reply to Mike Hommey [:glandium] from comment #0)
> It was used to force building components after libxul.

s/after/before/

> That's not necessary anymore with USE_LIBS \o/

s/USE_LIBS/FINAL_LIBRARY/

But that doesn't change that it's not required anymore.

        Attachment #8468144 -
        Flags: review?(mshal)

    
    

    
  


  

        Attachment #8468149 -
        Flags: review?(Pidgeot18)

        Attachment #8468144 -
        Flags: review?(mshal) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5bdf577bf6e0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34

    
    

    
  
Comment on attachment 8468149 [details] [diff] [review]
Remove app_libxul_dirs from c-c

Review of attachment 8468149 [details] [diff] [review]:
-----------------------------------------------------------------

Such bitrotting...

        Attachment #8468149 -
        Flags: review?(Pidgeot18) → review+

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.