Closed Bug 1049257 Opened 8 years ago Closed 8 years ago

Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: poiru, Assigned: poiru)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Removed an unrelated hunk which slipped into the previous patch.
Attachment #8468152 - Attachment is obsolete: true
Attachment #8468152 - Flags: review?(gps)
Attachment #8468155 - Flags: review?(gps)
Comment on attachment 8468155 [details] [diff] [review]
Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Review of attachment 8468155 [details] [diff] [review]:
-----------------------------------------------------------------

Please request re-review once this is rebased on top of bug 1045421.

::: toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
@@ +12,5 @@
>  
>  Cu.import("resource://testing-common/CrashManagerTest.jsm", this);
>  
>  const DUMMY_DATE = new Date(1391043519000);
> +const DUMMY_DATE_2 = new Date(1407284688000);

So yeah...

This test is disabled because of this hard-coded date silliness. I have a patch in bug 1045421 that should hopefully be reviewed and checked in within the next 24 hours.

Would you mind holding off a few hours and rebasing this on top of that bug? After all, this new test code isn't being executed because of the disabled test.
Attachment #8468155 - Flags: review?(gps) → feedback+
(In reply to Gregory Szorc [:gps] from comment #3)
> Comment on attachment 8468155 [details] [diff] [review]
> Fix typo in CrashManager.addCrash() in order to update the crash date of
> existing items
> 
> Review of attachment 8468155 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please request re-review once this is rebased on top of bug 1045421.

Done.
Attachment #8468155 - Attachment is obsolete: true
Attachment #8468775 - Flags: review?(gps)
Attachment #8468775 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/b261b836ac91
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.