1049257 - Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Comment 1

[Biru [:poiru]]

Attachment: Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Comment 2

[Biru [:poiru]]

Attachment: Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Removed an unrelated hunk which slipped into the previous patch.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8468155 [details] [diff] [review]
Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

Review of attachment 8468155 [details] [diff] [review]:
-----------------------------------------------------------------

Please request re-review once this is rebased on top of bug 1045421.

::: toolkit/components/crashes/tests/xpcshell/test_crash_manager.js
@@ +12,5 @@
>  
>  Cu.import("resource://testing-common/CrashManagerTest.jsm", this);
>  
>  const DUMMY_DATE = new Date(1391043519000);
> +const DUMMY_DATE_2 = new Date(1407284688000);

So yeah...

This test is disabled because of this hard-coded date silliness. I have a patch in bug 1045421 that should hopefully be reviewed and checked in within the next 24 hours.

Would you mind holding off a few hours and rebasing this on top of that bug? After all, this new test code isn't being executed because of the disabled test.

Comment 4

[Biru [:poiru]]

Attachment: Fix typo in CrashManager.addCrash() in order to update the crash date of existing items

(In reply to Gregory Szorc [:gps] from comment #3)
> Comment on attachment 8468155 [details] [diff] [review]
> Fix typo in CrashManager.addCrash() in order to update the crash date of
> existing items
> 
> Review of attachment 8468155 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please request re-review once this is rebased on top of bug 1045421.

Done.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b261b836ac91