1049285 - [e10s] Option lists overlaps <select> element when the list expand to the upward direction

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Alice0775 White]

This maybe happens with Windows Aero/Windows Classic visual style

Steps To Reproduce:
1. Enable e10s
2. Open https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/
3. Scroll to bottom
4. Attempt to change language
   Click Select box of "Other languages"

Actual Results:
  Option list start scroll automatically

Expected Results:
  Should not

Comment 1

[Chris Peterson [:cpeterson]]

Alice0775, is this select problem different than the e10s browser using Windows' native GUI controls instead of Firefox's own GUI controls? See also bug 978934.

Comment 2

[Alice0775 White]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> Alice0775, is this select problem different than the e10s browser using
> Windows' native GUI controls instead of Firefox's own GUI controls? See also
> bug 978934.

I think so,
Current e10s's select dropdown popup has autorepeat button at the top abd bottom of the popup instead of vertical scrollbar.

These autorepeat buttons interfere mouse interaction in this bug.

Comment 3

[Alice0775 White]

s/at the top abd bottom/at the top and bottom/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot of issue (non-e10s on left, e10s on right)

So this is us not using the right selection widget here. Instead, we use this popup that places the scroll arrow right under the mouse in the scenario that Alice put into comment 0. That causes immediate scroll, and it's not great.

This is very much related to bug 978934.

Comment 6

[Alice0775 White]

The problem does not fixed by bug 1053981. 
Re-opened

Comment 7

[Alice0775 White]

The problem is not fixed by bug 1053981.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Are you sure? I can no longer reproduce using the latest Nightly - the auto-scroll arrows are no longer at the top and bottom of the popup dialog. Bug 1053981 should have introduced a scrollbar instead. Can you show me a screenshot of what you're seeing?

Comment 9

[Alice0775 White]

Steps To Reproduce:
1. Enable e10s
2  Reduce window height so that expand the option list to the upward direction
3. Open https://addons.mozilla.org/en-US/firefox/addon/custom-buttons/
4. Scroll to bottom
5. Double Click the select Box

Actual Results:
  Option unexpectedly changed and page loaded.
  Because, the option list overlaps with the select box 

Expected Results:
  Should not change value of option

Comment 10

[Alice0775 White]

Attachment: screenshot Option lists overlaps

Comment 11

[Alice0775 White]

Attachment: select_bug.html

Comment 12

[Alice0775 White]

Attachment: screen shot after landing Bug 910022

Comment 14

[alex_mayorga]

This bugger is biting me on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 ID:20150408030205 CSet: 078128c2600a

Comment 15

[Jim Mathies [:jimm]]

We consider this a bit more serious since it can trigger form submits provided your mouse is directly over the popup area vs. the drop down arrow. Moving up to m7.

Comment 17

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #16)
> *** Bug 1156162 has been marked as a duplicate of this bug. ***

This reproduces in mac as well, there's a good video of this in Bug 1156162.

Comment 18

[Richard Newman [:rnewman]]

I don't think it's a dupe, Jim, unless this bug involves:

* Double-press selects on button press, but not on tap
* Opening the previous select when clicking another select elsewhere in the page

Certainly related, though.

Comment 19

[Richard Newman [:rnewman]]

Sorry, bad phrasing: not a _direct_ dupe; just don't want a potentially unrelated issue to get dropped by zealous duping.

Comment 20

[Neil Deakin]

It looks like we just need 873923 to be able to open a popup at a given rectangle instead of a point as the <select> popup is now.

Comment 21

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1049285-Use-openPopupAtScreenRect-method-for-ope.patch

Nice easy fix, provided the openPopupAtScreenRect patch from bug 873923 lands.

Comment 23

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9c6af2e2ec

Comment 24

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1e9c6af2e2ec

Comment 27

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 34.0a1 (Build ID: 20140805030300) on 
windows 8.1 pro 64-bit with the instructions from comment 0 .

Verified as fixed with Latest Firefox Nightly 43.0a1(Build ID: 20150822030206)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0

Comment 28

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug with Nightly 34.0a1 (2014-08-05) by following comment 0 on Linux x64

This Bug is now verified as fixed on Latest Firefox Nightly 43.0a1 (2015-08-26)

Build ID: 20150826030211
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

As it is also verified on Windows (Comment 27), Marking it as verified!