Closed Bug 1049303 Opened 9 years ago Closed 9 years ago

Invalid cast to ClientThebesLayer in ClientContainerLayer

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
29 Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Details

Attachments

(1 file)

Use a virtual instead of casting
2.51 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review 
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/client/ClientContainerLayer.h#72

This is an invalid cast if the layer is actually a ClientTiledThebesLayer.

This crashes on windows with tiling enabled. I have absolutely no explanation for how android/b2g are alive right now.

        Attachment #8468219 -
        Flags: review?(bas)

        Attachment #8468219 -
        Flags: review?(bas) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c20ec99f9a19
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34

    
  
Flags: needinfo?(matt.woodrow)

          You need to log in
          before you can comment on or make changes to this bug.