Closed Bug 104931 Opened 23 years ago Closed 22 years ago

LDAP modules needs to be installed with the browser

Categories

(Core :: Preferences: Backend, defect, P2)

Product:
Core
Component:
Preferences: Backend
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: mitesh, Assigned: rdayal)

References

Details

(Whiteboard: [adt2 rtm] [ETA 06/28])

Attachments

(1 file, 2 obsolete files)

updated patch
5.39 KB, patch
dmosedale
: review+
dveditz
: superreview+
jud
: approval+
Details | Diff | Splinter Review 
As part of fix to bug 104927, we need LDAp modules to go with the browser 
packages (browser.xpi). Creating a new bug to track the progress of the bug 
95525 on the trunk
Status: NEW → ASSIGNED
QA Contact: sairuh → lrg
Depends on: 104927
Blocks: 113387
mitesh is no longer with us. reassigning to default module owner. bug 113387
tracks the original list of mitesh bugs
Assignee: mitesh → bnesse
Status: ASSIGNED → NEW
QA Contact: lrg → sairuh
I don't know if this is Installer or Mail/News, but either way... LDAP -> dmose.
Assignee: bnesse → dmose
QA Contact: sairuh → yulian
Status: NEW → ASSIGNED
nominating -- this means autoconfig doesn't work in a nav-only install. It also
means people who have a nav-only Netscape 6.2 who upgrade to MachV get an ugly
warning caused by the 6.2 mozldap.dll that didn't get upgraded (bugscape bug 16551)

The initial comment was wrong, bug 95524 covered the problem on the 0.9.4 branch
Keywords: nsbeta1+
Adding Tao & Margaret. This doesn't exactly block bug 121332, but it does mean
autoconfig and LDAP won't work in this situation.
one of the culprits
Blocks: 121332
Attached patch Patch (obsolete) — — Splinter Review 
Trying to help out dmose here... Here's a patch based on what he said needed to
be done. I'm a bit concerned that the mozldap library doesn't appear in either
static build, but hey, I don't know anything about packaging... ;)
Tao: 121332 does not block the implementation of this bug in any way.  Removing.

Bnesse: hmmm, I think my description must not have been quite right. However,
this is a excellent start; thanks.  I'll run with it.
No longer blocks: 121332
Keywords: mozilla1.0.1
Target Milestone: --- → mozilla1.0.1
Er, what I meant to say is that this bug doesn't block 121332.
Priority: -- → P2
Rajiv, could you take over this bug? reassigning to rdayal.
Assignee: dmose → rdayal
Status: ASSIGNED → NEW
Is this going to get fixed? it's a trivial fix, please do it. This is Netscape
install bug(scape) 16551
Whiteboard: [adt2 rtm]
Comment on attachment 86875 [details] [diff] [review]
Patch

r=dprice
Attachment #86875 - Flags: review+
Comment on attachment 86875 [details] [diff] [review]
Patch

sr=dveditz
Attachment #86875 - Flags: superreview+
nsLDAPPrefsService.js is used only within Mail, dmose pointed out. Please find
new patch attached here without nsLDAPPrefsService.js being moved to the
browser section.
Oops seems like Dan sr-ed the earlier patch while i was posting the new patch.
The earlier patch would also work fine but the patch above (id=88024) avoids
installing an unnecessary file for the browser.
dprice and dveditz can u please look at the updated patch. thanks. - Rajiv.
Attachment #88024 - Flags: needs-work+
Comment on attachment 88024 [details] [diff] [review]
updated patch without moving nsLDAPPrefsService.js to browser section

On any platforms which have liblber, it needs to move also, as it's required by
libldap.
Attached patch updated patch — — Splinter Review 
patch updated as per dmose comments. 

Dan, can u please review this patch. thanks - Rajiv.
Attachment #86875 - Attachment is obsolete: true
Attachment #88024 - Attachment is obsolete: true
Dan (dveditz) can u please sr the latest patch. thanks, - Rajiv.
Comment on attachment 88375 [details] [diff] [review]
updated patch

sr=dveditz
Attachment #88375 - Flags: superreview+
ADT team: note that this causes bugscape 16551 in a nav-only install from 6.2 to
7.0 and moving files into a spot where they always get installed is low risk.
Status: NEW → ASSIGNED
Keywords: adt1.0.1
rajiv - can you pls land this on the trunk, and have yulian verify it. thanks!
The fix for this was checked into trunk on Friday 6/21. Marking as fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Yulian was asking me how to test this bug fix. To do a quick verification use
the Installer and install only the browser. Then go to below dirs and check the
below files :

 - bin/libldap50.*    on all platforms
 - bin/libprldap50.*  on all platforms
 - bin/liblber50.so   on Unix
 - bin/components/libmozldap.* on all platforms
 - bin/components/mozldap.xpt  on all platforms

The above files should exist.

However the real test to verify this is to install browser only and see if
autoconfig works.

 
Taking over this bug, I should be able to verify it fairly quickly as i have
autocongig and ldap test cases already set up.
QA Contact: yulian → lrg
I have been able to verify the fix on windows and linux and MacOS 9 using todays
trunk build;  i created an autoconfig.jsc file that sets the home page with a
value returned from an ldap querie.  There were no problems found, marking as
verified.
Status: RESOLVED → VERIFIED
Cool, thanks Luke.
adding adt1.0.1+.  Please check in after getting drivers approval.
Keywords: adt1.0.1 → adt1.0.1+
Keywords: approval
Whiteboard: [adt2 rtm] → [adt2 rtm] [ETA 06/28]
Attachment #88375 - Flags: approval+
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
fix checked on branch
Keywords: mozilla1.0.1+ → fixed1.0.1
Luke can u please verify this on 1.0.1 branch ?
I have verified that this fixx works on todays (20020628) Netscape Branch builds
on the following platforms:
Linux
MacOS9
Windows98
Windows2000

Marking verified1.0.1
Keywords: fixed1.0.1 → verified1.0.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: