1049310 - [1.4] TypeError: pendingOutgoingCall is null {file: "resource://gre/modules/ril_worker.js" line:3913}

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: fix pendingOutgoingCall=null

Comment 2

[shawn ku [:sku]]

Comment on attachment 8468216 [details] [diff] [review]
fix pendingOutgoingCall=null

Review of attachment 8468216 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3909,5 @@
>        } else {
>          if (newCall.state === CALL_STATE_DIALING ||
>              newCall.state === CALL_STATE_ALERTING) {
> +          if (pendingOutgoingCall) {
> +            newCall.isEmergency = pendingOutgoingCall.isEmergency;

Will it be possible that modem set up an ECC call via STK?
if so, should we set newCall.isEmergency to a correct value?

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to shawn ku [:sku] from comment #2)
> Comment on attachment 8468216 [details] [diff] [review]
> fix pendingOutgoingCall=null
> 
> Review of attachment 8468216 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_worker.js
> @@ +3909,5 @@
> >        } else {
> >          if (newCall.state === CALL_STATE_DIALING ||
> >              newCall.state === CALL_STATE_ALERTING) {
> > +          if (pendingOutgoingCall) {
> > +            newCall.isEmergency = pendingOutgoingCall.isEmergency;
> 
> Will it be possible that modem set up an ECC call via STK?
> if so, should we set newCall.isEmergency to a correct value?

3GPP TS 11.14
"""
It is possible for the SIM to request the ME to set up an emergency call by supplying the number "112" as called party number. If the SIM supplies a number stored in EFECC, this shall not result in an emergency call.
"""

It seems that only "112" is considered as an emergency call. We can do this check.

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #2 Fix pendingOutgoingCall=null

Comment 5

[shawn ku [:sku]]

(In reply to Szu-Yu Chen [:aknow] from comment #3)
> (In reply to shawn ku [:sku] from comment #2)
> > Comment on attachment 8468216 [details] [diff] [review]
> > fix pendingOutgoingCall=null
> > 
> > Review of attachment 8468216 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: dom/system/gonk/ril_worker.js
> > @@ +3909,5 @@
> > >        } else {
> > >          if (newCall.state === CALL_STATE_DIALING ||
> > >              newCall.state === CALL_STATE_ALERTING) {
> > > +          if (pendingOutgoingCall) {
> > > +            newCall.isEmergency = pendingOutgoingCall.isEmergency;
> > 
> > Will it be possible that modem set up an ECC call via STK?
> > if so, should we set newCall.isEmergency to a correct value?
> 
> 3GPP TS 11.14
> """
> It is possible for the SIM to request the ME to set up an emergency call by
> supplying the number "112" as called party number. If the SIM supplies a
> number stored in EFECC, this shall not result in an emergency call.
> """
> 
> It seems that only "112" is considered as an emergency call. We can do this
> check.

Most of cases, EF_ECC is empty. That's why ro.ril.ecclist/ril.ecclist is introduced.
I would suggest we check ro.ril.ecclist/ril.ecclist to complete the whole set.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8468274 [details] [diff] [review]
#2 Fix pendingOutgoingCall=null

Review of attachment 8468274 [details] [diff] [review]:
-----------------------------------------------------------------

Hey Aknow,

Shawn's comment 5 makes sense to me. Please address that, thank you!

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #3 Fix pendingOutgoingCall=null

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8468307 [details] [diff] [review]
#3 Fix pendingOutgoingCall=null

Review of attachment 8468307 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3913,5 @@
> +          if (pendingOutgoingCall) {
> +            newCall.isEmergency = pendingOutgoingCall.isEmergency;
> +          } else {
> +            // Don't set |isEmergency|
> +            // The correct value will be set in TelephonyService

Please remove the empty else clause but keep the comment. Thanks!

Comment 9

[shawn ku [:sku]]

[Blocking Requested - why for this release]: No call UI for STK call setup due to this exception. Dolphin/tarako is impacted.

Comment 10

[Wayne Chang [:wchang]]

As per comment 9, regression, high impact.

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: (1.4) [final] Fix pendingOutgoingCall=null. r=hsinyi

Comment 12

[Szu-Yu Chen [:aknow] (inactive)]

check-in needed, only for 1.4
https://tbpl.mozilla.org/?tree=Try&rev=ea10978cd991

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/892e68b8ae62