Closed Bug 104933 Opened 23 years ago Closed 20 years ago

Mozilla-generated .url filename without name when page has no title

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.2alpha

People

(Reporter: dolmen, Assigned: ben_seamonkey)

References

()

Details

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.4) Gecko/20010913
BuildID:    2001091303

When you drag the specified page bookmark to the Windows desktop to create an
Internet shortcut, the name of the file is ".URL" (no filename, just the suffix)
because the specified page has no title defined in HTML.



Reproducible: Always
Steps to Reproduce:
1. Drag the bookmark from the address bar to the Windows desktop.

Beginning of the page source is : 
<html><body bgcolor=


Proposed fix : set a default non empty filename.
Suggestions :
 - the filename part of the URL. This is what Microsoft IE does. (the
IE-generated shortcut is named "cansecwest-2001.URL")
 - a default name that should be localizable.
In method GetFileDescriptorInternetShortcut at 
http://lxr.mozilla.org/mozilla/source/widget/src/windows/nsDataObj.cpp#477
Depends on: 103466, 103468
confirming with win2k build 20011013..
Mozilla does not create a shortcut on win2k if the bookmakr have no title
Status: UNCONFIRMED → NEW
Ever confirmed: true
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Assignee: ben → pchen
Verified that it is in 0.9.6 (build 200112009).
mass reassign of pchen bookmark bugs to ben
Assignee: pchen → ben
This bug has a duplicate somewhere else, a bug that I filed on myself, and it
has a patch. 
Whiteboard: dupeme
This is not actually a dup. 
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: dupeme
Target Milestone: --- → mozilla1.2
Mass reassign of my non-Firefox bugs to ben_seamonkey@hotmail.com
Assignee: bugs → ben_seamonkey
Status: ASSIGNED → NEW
*** Bug 240110 has been marked as a duplicate of this bug. ***
This bug has a complete fix at bug 103468 if only I could get someone to show
interest in reviewing it.
Someone want to verify that this is fixed now that 103468 is checked in?
Would someone please verify this fixed and then mark closed.
Verified fixed with Moz Suite 1.8 nightly, build ID 2004061507. Using testcases
from bug 103468 (supplied URL doesn't seem to be valid anymore). This fix isn't
in Firefox, but probably should be.

Testcases...
http://bugzilla.mozilla.org/attachment.cgi?id=149729&action=view
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.