1049567 - Getting random translation offers on upgrade/whatsnew page

Status: RESOLVED DUPLICATE of bug 1049267

(www.mozilla.org :: Bedrock, defect)

Description

[:Gijs (he/him)]

See http://logs.glob.uno/?c=mozilla%23webdev#c217709 and further. Choice excerpts:

14:27	Osmose	Found the code! https://github.com/mozilla/bedrock...plates/tabzilla/tabzilla.js#L393
14:29	Osmose	And the view: https://github.com/mozilla/bedroc...r/bedrock/tabzilla/views.py#L69
14:29	Osmose	Looks like it should vary on accept-language
14:29	Osmose	But oddly
14:30	Osmose	It makes the request to /en-US/tabzilla/userlang.jsonp
14:30	Pike	https://www.mozilla.org/en-US/tabzilla/userlang.jsonp?callback=_ yeah
14:32	Osmose	It's using l10n_utils to get the accept_lang
14:32	Pike	I set my accept lang to fr, de, en-US, en
14:32	Pike	and it replies with
14:32	Pike	_({"languages": ["ru", "en-US", "en"]});
14:32	Osmose	https://github.com/mozilla/bedrock.../lib/l10n_utils/__init__.py#L82
14:32	Gijs	is the cache for that jsonp thing set to vary with accept-lang ? :)
14:33	Osmose	Gijs: The cache respects vary headers so yeah
14:33	Pike	with X-Cache-Info: cached
14:33	Gijs	Osmose: sure, but I thought that the views.py thing was for the actual main view
14:33	Gijs	Osmose: what I'm saying is, is the urlang.jsonp thing getting cached without regard for the Accept-Language header that requested it?
14:33	Osmose	It has that too, but I linked to the userlang.jsonp view
14:33	Gijs	oh
14:33	* Gijs shuts up :)
14:33	Osmose	Which has the vary
14:34	Osmose	Heh, no prob :P
14:34	Osmose	I wonder if it's a bug in get_accept_languages
14:34	Osmose	Pike: What's your full Accept-Languages header value?
14:34	Pike	fr, de, en-US, en
14:35	Pike	I wonder if zeus is keeping stuff around that it shouldn't
14:35	Osmose	Also possible and would match the symptoms better
14:36	Osmose	It's just weird because it varies, and Zeus is usually good about that
14:37	Osmose	Gijs: At this point it's most certainly worth a bug for the actual bedrock devs, at least. :D
14:38	Osmose	get_accept_languages seems to be fine
14:40	Pike	I get random user data :-)
14:40	Pike	_({"languages": ["es-MX", "es-ES", "es-AR", "es", "en-US", "en"]});