Closed Bug 1049598 Opened 11 years ago Closed 11 years ago

Intermittent browser_styleeditor_new.js | uncaught exception - TypeError: gNewEditor is null at browser_styleeditor_new.js:111

Categories

(DevTools :: Style Editor, defect)

Product:
DevTools
Component:
Style Editor
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox32 wontfix, firefox33 fixed, firefox34 fixed, firefox-esr24 unaffected, firefox-esr31 wontfix)

Status:
RESOLVED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- wontfix

People

(Reporter: emorley, Assigned: harth)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Rewrite test
6.66 KB, patch
bgrins
: review+
Details | Diff | Splinter Review
Ubuntu VM 12.04 x64 mozilla-inbound debug test mochitest-devtools-chrome-3 on 2014-08-06 07:09:18 PDT for push 860146d2669f slave: tst-linux64-spot-113 https://tbpl.mozilla.org/php/getParsedLog.php?id=45333303&tree=Mozilla-Inbound { 07:15:56 INFO - 4602 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | creating a new stylesheet added a new StyleEditor instance - creating a new stylesheet added a new StyleEditor instance 07:15:56 INFO - 4603 INFO Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}] 07:15:56 INFO - 4604 INFO Console message: [JavaScript Warning: "reference to undefined property mode.builtin" {file: "chrome://browser/content/devtools/codemirror/clike.js" line: 263}] 07:15:56 INFO - 4605 INFO Console message: [JavaScript Warning: "reference to undefined property arr[(arr.length - 1)]" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 7041}] 07:15:56 INFO - 4606 INFO Console message: [JavaScript Warning: "reference to undefined property options.clearRedo" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 6742}] 07:15:56 INFO - 4607 INFO Console message: [JavaScript Warning: "reference to undefined property cm.display.blinker" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 3134}] 07:15:56 INFO - 4608 INFO Console message: [JavaScript Warning: "reference to undefined property active[(active.length - 1)]" {file: "chrome://browser/content/devtools/codemirror/activeline.js" line: 53}] 07:15:56 INFO - 4609 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor is loaded when attached - new editor is loaded when attached 07:15:56 INFO - 4610 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor has isNew flag - new editor has isNew flag 07:15:56 INFO - 4611 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor has focus - new editor has focus 07:15:56 INFO - 4612 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor initially shows 0 rules - new editor initially shows 0 rules 07:15:56 INFO - 4613 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | content's background color is initially white - content's background color is initially white 07:15:56 INFO - 4614 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor has unsaved flag - new editor has unsaved flag 07:15:56 INFO - 4615 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property display.blinker" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 1375}] 07:15:56 INFO - 4616 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property e.codemirrorIgnore" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 6960}] 07:15:56 INFO - 4617 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property sPos.scrollLeft" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 3642}] 07:15:56 INFO - 4618 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property options.scroll" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 1156}] 07:15:56 INFO - 4619 INFO Console message: [JavaScript Warning: "ReferenceError: reference to undefined property built.bgClass" {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 834}] 07:15:56 INFO - 4620 INFO Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/codemirror/codemirror.js" line: 466}] 07:15:56 INFO - 4621 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor shows 1 rule after modification - new editor shows 1 rule after modification 07:15:56 INFO - 4622 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor shows 1 rule after modification - new editor shows 1 rule after modification 07:15:56 INFO - 4623 INFO TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor shows 1 rule after modification - new editor shows 1 rule after modification 07:15:56 INFO - 4624 INFO Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}] 07:15:56 INFO - 4625 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | uncaught exception - TypeError: gNewEditor is null at chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js:111 07:15:56 INFO - Stack trace: 07:15:56 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1302 07:15:56 INFO - null:null:0 - uncaught exception - TypeError: gNewEditor is null at chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js:111 07:15:56 INFO - Stack trace: 07:15:56 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1302 07:15:56 INFO - null:null:0 07:15:56 INFO - TEST-INFO | expected PASS 07:15:56 INFO - 4626 INFO JavaScript error: chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js, line 111: gNewEditor is null 07:15:56 INFO - 4627 INFO [1890] WARNING: NS_ENSURE_TRUE(mMutable) failed: file /builds/slave/m-in-l64-d-0000000000000000000/build/netwerk/base/src/nsSimpleURI.cpp, line 265 07:15:56 INFO - 4628 INFO TEST-OK | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | took 6546ms }
We need a fix or a backout here ASAP. This is quickly moving up the OrangeFactor ranks.
Flags: needinfo?(fayearthur)
Assignee: nobody → fayearthur
Flags: needinfo?(fayearthur)
Attached patch Rewrite test — — Splinter Review
That test had a bunch of race conditions, so I rewrote it. Try: https://tbpl.mozilla.org/?tree=Try&rev=ecfe08e48745
Attachment #8479417 - Flags: review?(bgrinstead)
Status: NEW → ASSIGNED
Comment on attachment 8479417 [details] [diff] [review] Rewrite test Review of attachment 8479417 [details] [diff] [review]: ----------------------------------------------------------------- Looks cleaner and tests are green. Please include bug id in commit message
Attachment #8479417 - Flags: review?(bgrinstead) → review+
Thanks a million, Heather! https://hg.mozilla.org/integration/fx-team/rev/5e7b290f7883
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5e7b290f7883
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
esr31 was a bit of a stretch. Backed out for test failures that aren't worth investigating. https://hg.mozilla.org/releases/mozilla-esr31/rev/78c5c9fca512
status-firefox-esr31: fixed → wontfix
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: