1049684 - Steeplechase tests are failing

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Syd Polk :sydpolk]

python /home/mozilla/jenkins/workspace/linux64-linux64/steeplechase/steeplechase/runsteeplechase.py --binary /home/mozilla/firefoxes/linux64/firefox/firefox --save-logs-to /home/mozilla/jenkins/workspace/linux64-linux64/logs --specialpowers-path /home/mozilla/firefoxes/linux64/tests/steeplechase/specialpowers --prefs-file /home/mozilla/firefoxes/linux64/tests/steeplechase/prefs_general.js --signalling-server http://172.16.141.51:8080 --html-manifest /home/mozilla/firefoxes/linux64/tests/steeplechase/tests/steeplechase.ini --host1 172.16.141.52:20701 --host2 172.16.141.53:20701


steeplechase INFO  | {"action":"test_unexpected_fail","message":"TypeError: constraints is undefined","time":1407340505216,"source_file":"harness"}
steeplechase INFO  | TypeError: constraints is undefined

This happens for each client.

Also happens on Sunny Day.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1049684_make_sdp_verification_steeplechase_compliant.patch

Try tree is currently closed.

Needinfo myself for submitting later.

Comment 2

[Nils Ohlmeier [:drno]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=50e61e865bb0

Comment 3

[Syd Polk :sydpolk]

Comment on attachment 8468779 [details] [diff] [review]
bug_1049684_make_sdp_verification_steeplechase_compliant.patch

Review of attachment 8468779 [details] [diff] [review]:
-----------------------------------------------------------------

Looks to me like you getting more info out of a test run when a test fails. I have no idea whether or not this will fix the failures, since I don't know this system. Somebody else should look at this.

Comment 4

[Syd Polk :sydpolk]

Comment on attachment 8468779 [details] [diff] [review]
bug_1049684_make_sdp_verification_steeplechase_compliant.patch

Review of attachment 8468779 [details] [diff] [review]:
-----------------------------------------------------------------

As I said before, I may not be the most qualified. However, it looks good to me.

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8468779 [details] [diff] [review]
bug_1049684_make_sdp_verification_steeplechase_compliant.patch

Byron as you reviewed the original patch, could you review this fix as well?
Basically the original patch broke on steeplechase, because the above added variables were not accessible when executed on two separate machines.

Comment 6

[Byron Campen [:bwc]]

Comment on attachment 8468779 [details] [diff] [review]
bug_1049684_make_sdp_verification_steeplechase_compliant.patch

Review of attachment 8468779 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b043d74aeb7b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b043d74aeb7b