Closed
Bug 1049744
Opened 10 years ago
Closed 10 years ago
[l10n] WebIDE: menus in the main windows should not truncate longer strings
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 34
People
(Reporter: flod, Assigned: jryans)
References
Details
Attachments
(3 files)
Given the amount of space available, we should do better than truncated the translation. Attached screenshot of the menus on an Italian build.
Assignee | ||
Comment 1•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=ee33ebea6796
Comment 2•10 years ago
|
||
If I used with and not min-width in the first place, it's because I was running into issues with panel sizing with min-width (panel's geometry is a bit magic). Please make sure this works on the 3 platforms, especially when there's a *vertical* overflow.
Comment 3•10 years ago
|
||
Tested on Linux. Appears to work as expected. Apparently, I can't reproduce the issues I mentioned in comment 2.
Updated•10 years ago
|
Attachment #8477520 -
Flags: review?(paul) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Windows appears to work as it does in the current Nightly build as well.
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e04d310ad616
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e04d310ad616
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
Flags: qe-verify+
Comment 7•10 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 Using latest l10n-it Nightly 20140916133140, I can still see the options truncated if Simulator is started (scroll bar becomes visible). This doesn't happen if WebIDE is opened in full screen. Is this expected or should I file a follow-up bug?
Flags: needinfo?(jryans)
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Petruta Rasa [QA] [:petruta] from comment #7) > Created attachment 8490760 [details] > itTruncatedOpt.png > > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 > > Using latest l10n-it Nightly 20140916133140, I can still see the options > truncated if Simulator is started (scroll bar becomes visible). This doesn't > happen if WebIDE is opened in full screen. > > Is this expected or should I file a follow-up bug? Hmm, I see what you mean... it seems the max-width is only applied when there is no vertical scrollbar. Yes, please file a new bug for this!
Flags: needinfo?(jryans)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(petruta.rasa)
Updated•10 years ago
|
Flags: needinfo?(petruta.rasa)
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•