1049820 - Make the Profiler Category and Framerate graphs themable

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Rob Campbell [:rc] (:robcee)]

Currently the Profiler Categories Graph is light theme only. It should adapt to dark theme too.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1049820-categories-graph-dark-theme.patch

Quick test added for this, as we'll be deprecating this in favour of the new perf tool.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=272dfbd96658

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: categories dark theme

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8544277 [details] [diff] [review]
1049820-categories-graph-dark-theme.patch

Review of attachment 8544277 [details] [diff] [review]:
-----------------------------------------------------------------

So metal

::: browser/devtools/shared/widgets/Graphs.jsm
@@ +1605,5 @@
>      let height = this._height;
>  
> +    // Draw the background.
> +    ctx.fillStyle = this.backgroundColor;
> +    ctx.fillRect(0, 0, width, height);

If you're doing this, remove the background from the css (if there is one, I can't remember). Probably in widgets.inc.css.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1049820-categories-graph-dark-theme.patch

Ah, you're right -- removing extra CSS

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2537c1b51a12

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for apparently causing ASAN leaks (at least it certainly seems like the most plausible candidate from the push).
https://hg.mozilla.org/integration/fx-team/rev/afbe988c3bea

https://treeherder.mozilla.org/logviewer.html#?job_id=1604782&repo=fx-team

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Confirmed green on the backout.

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Possibly related bug 1118582

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1049820-categories-graph-dark-theme.patch

another ASAN try https://treeherder.mozilla.org/#/jobs?repo=try&revision=b013932c5982

Comment 10

[Tim Nguyen :ntim]

Try looks good (I think), Should this be landed ?

Comment 11

[Jordan Santell [:jsantell] [@jsantell]]

the last ASAN try link has the obscure link failure as well, so this is not yet good to go

Comment 12

[Jordan Santell [:jsantell] [@jsantell]]

We do not currently have a categories graph, so removing this from bug 1110550

Comment 13

[Jordan Santell [:jsantell] [@jsantell]]

No longer have a category graph, and framerate graph responds to themes now, so closing this.