1049930 - Create builds for Dolphin on mozilla-central, mozilla-inbound, b2g-inbound, fx-team, and mozilla-aurora

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jason Smith [:jsmith]]

Dolphin is our target reference device for SPRD, so we need to ensure that we can test Dolphin on all branches under active development. This is especially important for allowing us to test Moz RIL, since Moz RIL is only supported officially on SPRD devices right now.

Current branch needs:

* m-c
* b2g32
* aurora
* b2g-inbound
* mozilla-inbound

Comment 1

[Jason Smith [:jsmith]]

Nick - Can you find someone to look into this? This will help unblock testing of Moz RIL on SPRD devices for other branches under development.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

We are currently building dolphin for 
* mozilla-b2g30_v1_4 only
* dep builds periodically, at 00:30, 6:30 and 12:30   (go into tinderbox-builds/)
* nightly builds twice a day, 00:02 and 16:02   (go into nightly/)
* eng and non-eng for both of those

So we should stop those and add the new branches, by the sounds of comment #0. Questions
* Are periodic builds still fine ? The alternative is on every landing
* We currently only do nightlies on m-c, aurora, and m-b2g32, you'd have tinderbox-builds for the rest. OK ?

Also, aurora has no device builds this cycle, but they'll be back for the next one and we can get the configuration done now.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Nick Thomas [:nthomas] from comment #2)
> We are currently building dolphin for 
> * mozilla-b2g30_v1_4 only
> * dep builds periodically, at 00:30, 6:30 and 12:30   (go into
> tinderbox-builds/)
> * nightly builds twice a day, 00:02 and 16:02   (go into nightly/)
> * eng and non-eng for both of those
> 
> So we should stop those and add the new branches, by the sounds of comment

Actually, we still need 1.4 builds right now, so we shouldn't stop generating builds there.

> #0. Questions
> * Are periodic builds still fine ? The alternative is on every landing

Periodic builds are fine to use.

> * We currently only do nightlies on m-c, aurora, and m-b2g32, you'd have
> tinderbox-builds for the rest. OK ?

Yes.

> 
> Also, aurora has no device builds this cycle, but they'll be back for the
> next one and we can get the configuration done now.

Right.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Turn on more dolphin builds

Adds these builders:
b2g_b2g-inbound_dolphin_periodic
b2g_b2g-inbound_dolphin_eng_periodic
--
b2g_mozilla-inbound_dolphin_periodic
b2g_mozilla-inbound_dolphin_eng_periodic
--
b2g_mozilla-central_dolphin_periodic
b2g_mozilla-central_dolphin_nightly
b2g_mozilla-central_dolphin_eng_periodic
b2g_mozilla-central_dolphin_eng_nightly
--
b2g_mozilla-b2g32_v2_0_dolphin_periodic
b2g_mozilla-b2g32_v2_0_dolphin_nightly
b2g_mozilla-b2g32_v2_0_dolphin_eng_periodic
b2g_mozilla-b2g32_v2_0_dolphin_eng_nightly

And should be the same on aurora as on mozilla-inbound.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8471315 [details] [diff] [review]
[buildbot-configs] Turn on more dolphin builds

https://hg.mozilla.org/build/buildbot-configs/rev/8832f208bfe9

Will go live in the next buildbot reconfig.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Which happened earlier today but the builds are burning; philor is going to hide them. Need to add b2g/config/dolphin/config.json to all the repos it's not in already.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Aurora's not an active B2G branch during this cycle. Why are we trying to schedule these builds there?

Also, does Bumper Bot need any changes or will things just work?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jason Smith [:jsmith] from comment #0)
> Dolphin is our target reference device for SPRD, so we need to ensure that
> we can test Dolphin on all branches under active development. This is
> especially important for allowing us to test Moz RIL, since Moz RIL is only
> supported officially on SPRD devices right now.

FWIW, numerous 1.4 blockers (primarily in RIL code no less) have been denied 2.0 uplift due to lack of applicability to that release. Not sure what this bug means for that.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

    1.68  for branch in BRANCHES:
    1.69 -    if branch not in ('mozilla-b2g30_v1_4',):
    1.70 +    if branch not in ('mozilla-b2g30_v1_4', 'mozilla-b2g32_v2_0',
    1.71 +                      'mozilla-aurora', 'mozilla-central', 'mozilla-inbound',
    1.72 +                      'b2g-inbound'):

Per the Job Visibility Policy, fx-team also needs to run these.
https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy#3.29_Runs_on_mozilla-central_and_all_trees_that_merge_into_it

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> Aurora's not an active B2G branch during this cycle. Why are we trying to
> schedule these builds there?

We're not actually. b2g builds are globally disabled on aurora by
 http://hg.mozilla.org/build/buildbot-configs/file/ad66388f3636/mozilla/b2g_config.py#l1230
They are added in the code block in comment #9 so that we get aurora builds when that is undone.

> Also, does Bumper Bot need any changes or will things just work?

Maybe, I will check.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Add fx-team

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Not sure what if any changes dolphin.xml is going to need on the non-1.4 branches of b2g-manifest as well.

Comment 13

[Jason Smith [:jsmith]]

Nick - After further discussion with rel man, they desire that we don't have Dolphin builds for 2.0, since we didn't uplift a bunch of patches to ensure Moz RIL works well on Dolphin on 2.0. That means we don't need the 2.0 builds. Can you remove them?

Sorry for the last minute change though.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8471315 [details] [diff] [review]
[buildbot-configs] Turn on more dolphin builds

I backed this out while I sort out bumper config and in-tree files.

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Combined patch, less mozilla-b2g32_v2_0

This combines the two earlier patches, and drops the mozilla-b2g32_v2_0 references. Carrying review over. Will land last, once everything else is in.

Comment 16

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [mozharness] Bump dolphin manifests, include spreadtrum mapping

This is written from inspection of the existing configs, and not well untested. The intention is to bump b2g/config/dolphin/sources.xml on b2g-inbound. I'll check it closer once we get repos synced.

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [b2g-inbound] WIP of config.json

* not sure if we need gecko+gaia updates or not
* missing sources.xml (depends on bumper setup)

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8473339 [details] [diff] [review]
[mozharness] Bump dolphin manifests, include spreadtrum mapping

This is copied over from the 1.4 config where we already had Dolphin builds.

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [b2g-inbound] in tree config and source manifest

* config.json is from copying the 1.4 file and updating the l10n paths, dropping b2g_manifest_branch
* sources.xml from running b2g_bumper locally

Comment 20

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8475075 [details] [diff] [review]
[b2g-inbound] in tree config and source manifest

https://hg.mozilla.org/integration/b2g-inbound/rev/b7d53b3626be

Comment 21

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8473339 [details] [diff] [review]
[mozharness] Bump dolphin manifests, include spreadtrum mapping

https://hg.mozilla.org/build/mozharness/rev/5f0136207f66 on default

Comment 22

[Pete Moore [:pmoore][:pete]]

Comment on attachment 8473339 [details] [diff] [review]
[mozharness] Bump dolphin manifests, include spreadtrum mapping

Attachment 8473339 [details] [diff] now merged into production branch too:
https://hg.mozilla.org/build/mozharness/rev/7771c9623c92

Comment 23

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b7d53b3626be

Comment 24

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8473257 [details] [diff] [review]
[buildbot-configs] Combined patch, less mozilla-b2g32_v2_0

in-tree files are merged around, and both builds work fine in staging (except for expected failures to upload to prod host).

https://hg.mozilla.org/build/buildbot-configs/rev/be307b08bbda

Comment 25

[Jordan Lund (:jlund)]

in production :)

Comment 26

[Nick Thomas [:nthomas] (UTC+12)]

Green. Unhidden on TBPL. All done.

Comment 27

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.