1049999 - Let the test run become failed when SimpleTest.js barfs on a parent.TestRunner call

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Martijn Wargers (dead)]

This is more or less a follow-up from bug 928678.
When SimpleTest.js throws on parent.TestRunner, it should cause the test run to become in a failed state.

Comment 1

[Martijn Wargers (dead)]

Attachment: 1049999.diff

This should be tested on try first, to see if it would catch failures, but tryserver is currently closed.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8468935 [details] [diff] [review]
1049999.diff

Review of attachment 8468935 [details] [diff] [review]:
-----------------------------------------------------------------

nice!

Comment 3

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=0cbc24350166

Comment 4

[Martijn Wargers (dead)]

Tryserver is all green (the oranges don't have anything to do with this).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f442079ac95f

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f442079ac95f

Comment 7

[Ed Morley [:emorley]]

Filed bug 1051775 for making this turn the run orange, since at the moment it doesn't.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5e1e03a7e25c