Closed Bug 1049999 Opened 5 years ago Closed 5 years ago

Let the test run become failed when SimpleTest.js barfs on a parent.TestRunner call

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(firefox33 fixed, firefox34 fixed)

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- fixed
firefox34 --- fixed

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

Details

Attachments

(1 file)

This is more or less a follow-up from bug 928678.
When SimpleTest.js throws on parent.TestRunner, it should cause the test run to become in a failed state.
Attached patch 1049999.diffSplinter Review
This should be tested on try first, to see if it would catch failures, but tryserver is currently closed.
Attachment #8468935 - Flags: review?(jmaher)
Comment on attachment 8468935 [details] [diff] [review]
1049999.diff

Review of attachment 8468935 [details] [diff] [review]:
-----------------------------------------------------------------

nice!
Attachment #8468935 - Flags: review?(jmaher) → review+
Tryserver is all green (the oranges don't have anything to do with this).
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f442079ac95f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Depends on: 1051157
Filed bug 1051775 for making this turn the run orange, since at the moment it doesn't.
Depends on: 1051775
You need to log in before you can comment on or make changes to this bug.