Closed Bug 1050060 Opened 5 years ago Closed 5 years ago

Clean up MP4 range calculation

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: ajones, Assigned: ajones)

References

Details

Attachments

(5 files, 2 obsolete files)

The MP4 range calculation has become messy and requires some clean up.
Attached patch Fix MP4 range pinning (obsolete) — Splinter Review
Attachment #8469001 - Flags: review?(edwin)
Attachment #8469001 - Attachment is obsolete: true
Attachment #8469001 - Flags: review?(edwin)
Attachment #8469000 - Attachment is obsolete: true
Attachment #8469000 - Flags: review?(edwin)
Comment on attachment 8468998 [details] [diff] [review]
Clean up MP4 index fields

Review of attachment 8468998 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/Box.cpp
@@ +57,5 @@
>      mChildOffset = headerRange.mEnd;
>    }
>  
>    MediaByteRange boxRange(aOffset, aOffset + size);
> +  if (mChildOffset > boxRange.mEnd ||

Since boxRange is [), this should be |>=|.
Attachment #8468998 - Flags: review?(edwin) → review+
Comment on attachment 8469060 [details] [diff] [review]
Optimise MP4 range calculation

Review of attachment 8469060 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/MoofParser.cpp
@@ +56,5 @@
>  MoofParser::ParseMdia(Box& aBox, Tkhd& aTkhd)
>  {
>    for (Box box = aBox.FirstChild(); box.IsAvailable(); box = box.Next()) {
>      if (box.IsType("mdhd")) {
> +      if (aTkhd.mTrackId == aTkhd.mTrackId) {

um...?
Attachment #8469060 - Flags: review?(edwin) → review+
Duplicate of this bug: 1052926
You need to log in before you can comment on or make changes to this bug.