1050067 - [FFOS 1.4] Fail to show two IMEIs when dialing *#06# the first time.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[ting.yang]

Steps to reproduce:
     The first time you dail *#06# which has no sim card or one sim card,it show generic failur,fail to show two IMEI.after that,it work well.if you restart the telephone,it will appear again.

Actual results:

show generic failur the first time

Expected results:

show two IMEI

thanks.

Comment 1

[Gabriele Svelto [:gsvelto] (PTO)]

Attachment: [PATCH] Correctly provide the service code when requesting an IMEI number

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8469570 [details] [diff] [review]
[PATCH] Correctly provide the service code when requesting an IMEI number

Review of attachment 8469570 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thank you!

Comment 3

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks for the quick review Hsin-Yi! This is ready to land; it's JS code and not covered by unit-tests AFAIK so a try run won't tell us much but it was already tested on a device where it fixes the problem, see bug 1002327 comment 93.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f50b633a185c

Is there any way we can add a test for this in automation?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f50b633a185c

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #4)
> Is there any way we can add a test for this in automation?

It's been a long-term objective of the dialer team to add emulator-based testing of the dialer functionality:

https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Long-Term_Project_Ideas

This would naturally cover cases such as this in the RIL; unfortunately little work has been done until now and testing is still mostly manual (with all the risks of regressions this entails).