1050085 - Improve l10n comments

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Francesco Lodolo [:flod]]

profiler.dtd

Given the structure profilerUI.emptyNotice1+2 and profilerUI.stopNotice1+2, I'd assume these strings are concatenated with a button in the middle, like it happens on the Network tab. The localization comment should clearly explain that.

Typo in comment for profilerUI.clearButton: "remvoes all the recordings"

profiler.properties

recordingsList.itemLabel=Recording #%S

What's %S? Given the #, I'd say a number, but I shouldn't be guessing it. There should be an explanation of what %S is in the comment, and an example.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Address comment issue in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1160900#c11

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Address comment issue in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1082695#c24

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1050085-l10n-cleanup.patch

Seems like most of these were taken care of already, but here are the remaining ones

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8643413 [details] [diff] [review]
1050085-l10n-cleanup.patch

Review of attachment 8643413 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/af32ff6a086c

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af32ff6a086c