Closed
Bug 1050095
Opened 8 years ago
Closed 8 years ago
[Text Selection] Prevent generate too much unwanted event when calling SelectionCarets::SelectWord.
Categories
(Core :: DOM: Selection, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Right now SelectWord will generate 4 selection change events with drag reason and 1 selection change event with mouse up reason. 4 drag events are useless and will cause some bug when showing utility bubble. So we need prevent those events be fired.
|
Assignee | |
Comment 1•8 years ago
|
||
SetSelectionDragState will call StartBatchChanges()/EndBatchChanges so that only mouseup event would be fired.
Attachment #8469058 -
Flags: review?(roc)
Attachment #8469058 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
try push: https://tbpl.mozilla.org/?tree=Try&rev=6b01a626344e
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7678c812fce6
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7678c812fce6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•